Repository navigation
Fix iPad pointer and trackpad input - #96
alantangok wants to merge 2 commits into
Conversation
|
@SandiyosDev |
I'll review your changes in the next two weeks, if you'd like to help me get your changes merged faster, please test these PRs on your personal device as well Thank you for your PRs |
|
Thanks for the update! I’ll test the relevant changes on my iPad and run regression checks on my iPhone, then post the device models, OS versions, and results on each PR to help streamline the review. |
|
thanks for the split, reviewing this one first as you asked. One thing from my own testing before the code, on my iPad (iPadOS 16.6.1) a left click under pointer lock comes in as a direct touch with an empty buttonMask, not as an indirect pionter touch, so in relative mode the new recognizer won't see the click at all and it falls through to the finger path, that's the jump #88 was about which iPadOS did you test on, and did you try a host that captures the cursor? If you can make the locked click case work, I'll test your builds on my iPad to see if the bug can be reproduced... |
|
And a code review, the gate/mapper enums just return their argument, inline them, and pointerButtonTouchSupported is always true at our deployment target so the GameController button handlers are dead code now |
|
Hi, and thank you for working on this. I would like to report a trackpad problem that appears to match what this PR addresses, and I am happy to test a build if one is available. Setup:
Symptoms:
If you can share an unsigned IPA or an AltSource build of this branch, I can test it on my iPad and report back with results. Thanks again. |
@MoustacheOff |
|
Fully fixed! Many thanks. |
@MoustacheOff Yes, you can create an issue and reference this thread, so it's easier to track |
|
Thanks @SandiyosDev for the review and for following up on the pointer issues in 1.4.0, and thanks @MoustacheOff for testing and confirming the fix on your setup. I appreciate the time and care you both put into this. |
Summary
UIHoverGestureRecognizeras the sole absolute movement producerVerification
.checkpoint, orscripts/changesDevice validation still required
Split from #93.