Repository navigation
Add bounded iPad pinch zoom viewport - #98
alantangok wants to merge 2 commits into
Conversation
|
and there are two things I can see from the code alone, in direct mode the follow is skipped entirely and the scroll view's own panning is disabled so a zoomed view can't be moved, and the clamp is gated on the pinch toggle instead of the zoom scale so turning zoom off while zoomed leaves it unclamped. savedZoomEnabled is also still declared with nothing reading it, so anyone who had it on loses zoom on update |
|
The keyboard height fix is good on its own, if you open that as its own PR I can take it now |
|
the keyboard height fix is in #107 with you as the author, rest conflicts with main now, so closing this one |
|
Thanks @SandiyosDev for the detailed review and for extracting and merging the keyboard-height fix in #107. I understand the concerns with the broader zoom changes, especially preserving the existing default behavior and fixing the Direct-mode and settings cases. I appreciate you taking the useful part forward and explaining what still needs work. |
Summary
Verification
.checkpoint, orscripts/changesDevice validation still required
Split from #93.