Check PHP syntax in CI at the declared floor - #4
Merged
Merged
Conversation
The PHPCompatibility release in the lock is 9.3.5, which has no PHP 8 sniffs. A file using a typed class constant passes it with testVersion 8.2-. Parsing each file with the 8.2 binary catches syntax the floor does not support. It does not catch newer functions such as json_validate().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 moved the PHPCS
testVersionto 8.2, but the PHPCompatibility release in the lock is 9.3.5, which predates PHP 8. A file with a typed class constant passes it. This adds aphp -lpass on the 8.2 runner, which does catch that.It only catches syntax. A newer function such as
json_validate()still gets through, and closing that needs PHPCompatibility 10, which has no stable release.