Cache the contents of an uploaded SVG icon - #8
Merged
Merged
Conversation
uploaded_icon_markup() read the file on every render. Where uploads are in remote storage such as S3 Uploads, that is a network request per icon button per uncached page view. The entry is keyed on the attachment's modified time and has no expiry, so there is no TTL to pick and updating the attachment retires it. Only the file contents are cached, so one entry serves every size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An uploaded icon was read from disk on every render. With uploads in remote storage such as S3 Uploads, that is a network request per icon button per uncached page view.
The entry is keyed on the attachment's modified time and has no expiry, so there was no TTL to guess at. The tradeoff is that a file replaced in place, with nothing updating the attachment, keeps serving the old contents until the cache is flushed.
SECURITY.mdcovers what that means for sanitising a file that is already uploaded.