Repository navigation
fix(e2e): escape test values in locator patterns with one helper - #732
Merged
Merged
Conversation
Six e2e specs built a RegExp straight from a test value. semgrep flags these as non-literal patterns on every main run. A value holding `.`, `(` or `+` would also have matched more than its own row. The rx tagged template in e2e/config/regex.helpers.ts escapes every interpolation and keeps the template's raw backslashes. The one RegExp call left has a semgrep marker explaining that the values are the test's own data.
The marker dropped the trailing segment of the rule id reported by the scan. A suppression under the wrong id is not honoured. oidcLogin.spec.ts has the full id. The helper's marker now matches it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six e2e specs built a RegExp straight from a test value. semgrep flags these as non-literal patterns on every main run. A value holding
.,(or+would also have matched more than its own row.The rx tagged template in e2e/config/regex.helpers.ts escapes every interpolation and keeps the template's raw backslashes. The one RegExp call left has a semgrep marker explaining that the values are the test's own data.