Repository navigation
fix(ci): eliminate 141 redundant prover jobs without losing exercised tests - #136
hyperpolymath wants to merge 2 commits into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
Superseded by merged #133 (commit 591e6f3). Both the prover-independent transport gate and PR-scoped cancellation commits were cherry-picked, and the replacement two-job Backend Matrix passed on the combined branch. Verified the new workflow on main; closing this separate PR to avoid duplicate changes, not representing it as independently merged. |



Measured CI problem
VCL-UT's
Backend Matrixexpanded Echidna's 141 prover slugs into 141 Rust jobs (max-parallel: 3; GitHub listed 142 jobs including the prep job). The PR waits behind at least 47 waves of almost identical jobs. This is distinct from Gitleaks, which usually completes in seconds once it starts.The per-prover smoke was not real per-prover verification: it passed
ECHIDNA_PROVERinto each job but neithersrc/interface/echidna-client/src/nortests/reads the environment variable. Every job runs the samecargo test --manifest-path src/interface/echidna-client/Cargo.toml --testssuite against wiremock endpoints. These tests establish transport semantics for OpenTheory/Dedukti and HTTP errors, not behaviour of 141 distinct prover engines. The prior UI advertised per-backend evidence that did not exist.Fix
.machine_readable/provers.a2ml, now validating nonempty, correctly shaped, uniquely named slugs and consistency with its declared count.cargo testcommand.ECHIDNA_PROVERbegins appearing in the client source or tests, the single-suite lane fails and demands genuine prover-specific assertions / restoration of the matrix before a green claim.Backend Matrixworkflow identity; no test suite is disabled, no CI bypass, and no source-level proof claim is made.Verification
actionlint .github/workflows/backend-matrix.yml: PASS.git diff --check: PASS.0ee0c7csigned and verified (G).The actual client cargo test and live GitHub Actions run must confirm the revised workflow. This change intentionally does not purport to test distinct prover implementations; adding real per-prover semantics requires a separate substantive test design.