Complete View correctness, lifecycle, and Laravel parity - #477
Merged
Conversation
Publish inline Blade templates through the existing atomic filesystem replacement boundary, accept only exact file sizes, and repair missing or partial artifacts without rejecting legitimate empty templates. Bound retained component lookup keys with xxh128 and replace the reserved component namespace instead of accumulating stale paths. Add counterfactual coverage for atomic publication, complete-file cache hits, empty and truncated files, fixed-size keys, namespace replacement, cache reuse, and static cache cleanup.
Bring component attributes, slots, dynamic component names, and nested conventional component discovery in line with the current Laravel-facing contracts. Terminate existing style defaults correctly, expose accurate exception metadata, accept backed enum component names, and default unnamed slots without weakening strict compiler paths. Port focused coverage for style merging, nested component class resolution, unnamed slots, and enum-backed dynamic component rendering while retaining Hypervel component registration semantics.
Give transient section, footer, raw-block, and echo-format state explicit compile-pass and coroutine ownership while retaining worker-level compiler defaults. Restore current protected compiler contracts, immutable parent placeholders, conditional stack parsing, strict token handling, and the compiler v3 cache boundary without locks, clones, or request-scoped services. Memoize only verified-fresh compiled views and release the compiled-path stack through finally on every success or failure path. Add deterministic coverage for sequential and concurrent compilation, nested and exceptional echo overrides, Mail compilation, footer and directive extension hooks, cache-disabled recompilation, deleted files, and diagnostic cleanup.
Flush component slots, slot stacks, and loop frames with the Factory state they belong to so failed renders cannot retain slot content or corrupt later loop metadata. Preserve eager rendering only when a mutable View becomes stored section content, and keep yield defaults lazy when a section already exists. Add regressions for retained slot state, failed-render loop cleanup, uncountable loops, copied coroutine contexts, unused View defaults, strict loop identity, named arguments, and the existing request-shared-data lifecycle.
Publish the complete compiler configuration in Foundation, consume those canonical values without duplicate provider fallbacks, and restore public provider registration extension points. Use consistent container resolution in the edited provider closures and document worker-lived resolver and compiler mutators at their actual lifecycle boundaries. Restore finder named-argument parity and add focused coverage for provider visibility, resolver replacement, canonical configuration defaults, finder behavior, and split application configuration merging.
Declare the Symfony contracts View uses directly, remove false Foundation and Validation requirements, and retain Foundation only as an optional integration for generated Vite and font directives. Delete the unused validation middleware rather than carrying dead source and a dependency solely for it. Add manifest coverage that keeps split Symfony constraints aligned with the monorepo root, verifies deliberate dependency omissions and suggestions, and pins provider discovery in both package and root metadata.
Regenerate the Blade and View facade method annotations from the corrected concrete APIs. The generated surface now reflects the supported stringable callback domain and static parent placeholder contract while removing the superseded Hypervel-only placeholder getter. Keeping these generated files in their own commit makes the mechanical public metadata update easy to compare with the source changes that produced it.
Canonicalize view cache roots, collapse trailing-separator duplicates, and reject only true descendants at a directory boundary. Preserve filesystem roots and path-prefix siblings so deployment-time compilation neither duplicates nested trees nor drops unrelated directories. Use consistent make-based View resolution throughout the command and add counterfactual coverage for nested roots, prefix siblings, missing paths, duplicate separators, and a filesystem root containing a nested view directory.
Port the current full-application Blade, anonymous component, and renderable exception scenarios into package-scoped Hypervel integration tests. Include the complete template fixture set for components, slots, scoped includes, dynamic calls, alternate extensions, appendable attributes, and exception rendering. The integration surface also exercises configured Blade extensions and cache-root deduplication through the real application container while preserving Hypervel bootstrap and coroutine conventions.
Explain compiled-view freshness in worker terms, recommend deployment-time view caching, and describe when live workers require an explicit cache clear after local edits. Keep the user guidance in Laravel-style prose without exposing coroutine-context or internal cache implementation details. Update the package README with its documentation and upstream references plus the two public Hypervel differences developers need to account for: alias-first component registration and eager rendering when a View becomes stored section content.
Record the signed-off View design, findings, rejected machinery, performance boundaries, test strategy, and final implementation state. Close the package checklist and routing index while carrying the completed view-01 and reflection-02 revalidations and the Foundation and Translation cross-package ownership entries. The records distinguish retained slot memory from loop-output corruption, document the Xdebug-only parser branch without a synthetic seam, and leave no View TODO, deferred defect, compatibility workaround, or open workflow step.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR completes a View lifecycle audit. It adds coroutine-safe compiler and render-state cleanup, compiled-view cache configuration, component publication fixes, dependency updates, API corrections, documentation, and extensive View integration and regression tests. ChangesView lifecycle and correctness
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant ViewFactory
participant CompilerEngine
participant BladeCompiler
participant CoroutineContext
ViewFactory->>CompilerEngine: Render view
CompilerEngine->>BladeCompiler: Compile or reuse compiled view
BladeCompiler->>CoroutineContext: Store temporary state
CompilerEngine->>ViewFactory: Return rendered output
CompilerEngine->>CoroutineContext: Clear compiled-path state
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR completes a broad View-package correctness and Laravel-parity pass while adapting transient compiler and render state to Hypervel’s long-lived coroutine workers.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/view/src/Compilers/BladeCompiler.php | Adds compile-pass ownership and cleanup, directive argument parsing, component publication safeguards, and restored compiler extension APIs without an eligible unresolved finding. |
| src/view/src/Engines/CompilerEngine.php | Adds verified-fresh memoization, deleted-compiled-file recovery, and exhaustive compiled-path cleanup consistent with the documented worker-lifetime cache model. |
| src/view/src/Factory.php | Extends render-state cleanup so transient component, slot, and loop state does not remain in coroutine context. |
| src/view/src/Concerns/ManagesComponents.php | Corrects component and slot lifecycle cleanup after rendering. |
| src/view/src/Concerns/ManagesLayouts.php | Revises parent-placeholder and section storage behavior while preserving lazy defaults. |
| src/foundation/src/Console/ViewCacheCommand.php | Deduplicates canonical view roots by directory boundaries without conflating path-prefix siblings. |
| src/testbench/src/PHPUnit/TestCase.php | Assigns caller-dependent exception-handler restoration to the raw Testbench base while preserving exhaustive teardown. |
| src/testing/src/PHPUnit/AfterEachTestSubscriber.php | Centralizes framework static-state cleanup and includes the newly standardized View reset hooks. |
| src/view/src/ViewServiceProvider.php | Consumes canonical View configuration and restores provider extension points and engine wiring. |
| src/view/composer.json | Corrects direct split-package dependencies and removes false Foundation and Validation requirements. |
Reviews (3): Last reviewed commit: "fix(view): clear compile-pass state on f..." | Re-trigger Greptile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
src/support/src/Facades/Blade.php (1)
48-48: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueImport
Closurefor this annotation.Line 48 uses the fully qualified
\Closurename. Adduse Closure;and useClosure|stringin the annotation. The source rule requires imports instead of fully qualified class names outside configuration-style identifier lists.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/support/src/Facades/Blade.php` at line 48, Update the Blade facade annotations by importing Closure with a use statement and changing the stringable method annotation to use Closure|string instead of the fully qualified \Closure name.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/view/src/Component.php`:
- Line 156: Update the Component class by adding a public flushState(): void
method at the end, with the exact docblock title “Flush all static state.” Clear
every static cache and reference there, including
static::$ignoredParameterNames, while preserving the existing flushCache()
behavior.
In `@src/view/src/Engines/CompilerEngine.php`:
- Around line 52-83: At the end of the CompilerEngine class, add the public
static flushState(): void API with the exact docblock title “Flush all static
state.” and reset the compiledOrNotExpired static cache. Preserve
forgetCompiledOrNotExpired() as a compatibility wrapper by having it delegate to
flushState() rather than removing it.
In `@src/view/src/FileViewFinder.php`:
- Around line 52-62: Restore the public find() parameter name to $name in both
ViewFinderInterface and FileViewFinder so named calls using find(name: ...)
remain compatible. Update the method body and its calls to findNamespacedView()
and findInPaths() consistently, preserving the existing lookup behavior.
In `@tests/Integration/View/BladeTest.php`:
- Around line 257-270: Move HelloComponent from
tests/Integration/View/BladeTest.php lines 257-270 into a Fixtures file under
the Hypervel\Tests\Integration\View\BladeTest namespace. Move
RenderableException from tests/Integration/View/RenderableViewExceptionTest.php
lines 34-40 into a Fixtures file under the
Hypervel\Tests\Integration\View\RenderableViewExceptionTest namespace, and
update the view fixture that instantiates it to use the new namespace.
In `@tests/View/Blade/BladePushTest.php`:
- Around line 89-100: Update parseConditionalStackExpression() to split the
directive arguments at the final top-level comma, preserving commas inside the
stack argument and condition expressions; replace the current explode()-based
parsing and add a test covering `@pushIf`(true, 'body,end') with the expected
compiled output.
---
Nitpick comments:
In `@src/support/src/Facades/Blade.php`:
- Line 48: Update the Blade facade annotations by importing Closure with a use
statement and changing the stringable method annotation to use Closure|string
instead of the fully qualified \Closure name.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 745a4acb-8fa6-49f3-b4e6-41e2cbcda36d
📒 Files selected for processing (78)
docs/plans/2026-07-12-0900-framework-coroutine-state-lifecycle-audit.mddocs/plans/2026-07-12-0915-framework-coroutine-state-lifecycle-audit-ledger.mddocs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.mdsrc/boost/docs/views.mdsrc/foundation/config/view.phpsrc/foundation/src/Console/ViewCacheCommand.phpsrc/support/src/Facades/Blade.phpsrc/support/src/Facades/View.phpsrc/view/README.mdsrc/view/composer.jsonsrc/view/src/Compilers/BladeCompiler.phpsrc/view/src/Compilers/Compiler.phpsrc/view/src/Compilers/ComponentTagCompiler.phpsrc/view/src/Compilers/Concerns/CompilesConditionals.phpsrc/view/src/Compilers/Concerns/CompilesContexts.phpsrc/view/src/Compilers/Concerns/CompilesEchos.phpsrc/view/src/Compilers/Concerns/CompilesErrors.phpsrc/view/src/Compilers/Concerns/CompilesLayouts.phpsrc/view/src/Compilers/Concerns/CompilesSessions.phpsrc/view/src/Component.phpsrc/view/src/ComponentAttributeBag.phpsrc/view/src/ComponentSlot.phpsrc/view/src/Concerns/ManagesComponents.phpsrc/view/src/Concerns/ManagesLayouts.phpsrc/view/src/Concerns/ManagesLoops.phpsrc/view/src/DynamicComponent.phpsrc/view/src/Engines/CompilerEngine.phpsrc/view/src/Engines/EngineResolver.phpsrc/view/src/Factory.phpsrc/view/src/FileViewFinder.phpsrc/view/src/Middleware/ValidationExceptionHandle.phpsrc/view/src/View.phpsrc/view/src/ViewServiceProvider.phptests/Foundation/Console/ViewCacheCommandTest.phptests/Foundation/FoundationConfigTest.phptests/Integration/View/BladeAnonymousComponentTest.phptests/Integration/View/BladeTest.phptests/Integration/View/RenderableViewExceptionTest.phptests/Integration/View/anonymous-components-1/app.blade.phptests/Integration/View/anonymous-components-2/buttons/danger.blade.phptests/Integration/View/anonymous-components-2/panel.blade.phptests/Integration/View/anonymous-components-templates/page.blade.phptests/Integration/View/templates/components/appendable-panel.blade.phptests/Integration/View/templates/components/base-input.blade.phptests/Integration/View/templates/components/child-input.blade.phptests/Integration/View/templates/components/hello-span.blade.phptests/Integration/View/templates/components/input-with-slot.blade.phptests/Integration/View/templates/components/link.blade.phptests/Integration/View/templates/components/menu-item.blade.phptests/Integration/View/templates/components/menu.blade.phptests/Integration/View/templates/components/panel.blade.phptests/Integration/View/templates/consume.blade.phptests/Integration/View/templates/different-extension.shtests/Integration/View/templates/hello.blade.phptests/Integration/View/templates/partials/scoped-partial.blade.phptests/Integration/View/templates/renderable-exception.blade.phptests/Integration/View/templates/uses-appendable-panel.blade.phptests/Integration/View/templates/uses-child-input.blade.phptests/Integration/View/templates/uses-include-regular.blade.phptests/Integration/View/templates/uses-include-scoped.blade.phptests/Integration/View/templates/uses-link.blade.phptests/Integration/View/templates/uses-panel-dynamically.blade.phptests/Integration/View/templates/uses-panel.blade.phptests/Integration/View/templates/varied-dynamic-calls.blade.phptests/Mail/MarkdownCoroutineSafetyTest.phptests/View/Blade/BladeComponentTagCompilerTest.phptests/View/Blade/BladePushTest.phptests/View/ComponentTest.phptests/View/DynamicComponentTest.phptests/View/PackageMetadataTest.phptests/View/ViewBladeCompilerTest.phptests/View/ViewCompilerEngineTest.phptests/View/ViewComponentAttributeBagTest.phptests/View/ViewEngineResolverTest.phptests/View/ViewFactoryTest.phptests/View/ViewFileViewFinderTest.phptests/View/ViewServiceProviderTest.phptests/View/ViewTest.php
💤 Files with no reviewable changes (1)
- src/view/src/Middleware/ValidationExceptionHandle.php
Replace comma-based Blade directive splitting with a shared top-level parser backed by PHP's tokenizer. The parser keeps commas inside strings, interpolation, arrays, calls, attributes, and other nested expressions while retaining the cheap path for expressions without commas. Apply the corrected boundary to conditional stacks, once-only push and prepend directives, and @JSON. This preserves JSON_HEX defaults and explicit depth, keeps generated IDs correct, and prevents malformed compiled output for nested expressions. Add focused regressions for literal and nested commas, interpolated strings, generated once IDs, and JSON encoding options. The work remains compilation-only and adds no render-time path.
Give Component and CompilerEngine standard flushState hooks and route framework test cleanup through them. Component cache cleanup now covers ignored parameter metadata as well as reflection and Blade caches while retaining the narrower production reset APIs. Keep internal cleanup and metadata methods out of component template data, synchronize the documented reserved names, and pin the exact public component data surface. Complete the touched component/compiler method metadata and slot-context return type. Add focused coverage for every static field, both CompilerEngine reset entry points, and the component exposure boundary so future worker-global additions cannot silently escape cleanup or become callable from templates.
Remove Testbench Foundation Application's duplicate registry of framework static resets. The authoritative after-test subscriber already owns those resets, and keeping a second list allowed the two registries to drift. Move the one caller-dependent reset into the raw Testbench PHPUnit base: exception-handler restoration requires the active test case. Its teardown now retains the earliest failure while still performing Mockery verification and cleanup, matching the Components base lifecycle. Remove redundant test teardown calls, retain only test-owned resource cleanup, and extend the shared failure regression to prove both base cases still verify and close Mockery when handler restoration throws.
Extend the View findings through view-40 for directive parsing, static cleanup, internal component exposure, and touched method metadata. Record the final ownership model, rejected parser and lifecycle machinery, compile-time-only cost, and upstream-ready Blade defects. Route the genuine Boost, Foundation, Testbench, and Testing implications through the dependency index and completed-package records. Mark implementation, validation, self-review, and independent code review complete with no deferred View issue or stale in-progress wording.
Collaborator
Author
|
@coderabbitai Thanks for the review. The follow-up is pushed in four focused commits. Implemented:
Two suggestions were intentionally not applied:
The full repository gate was green before the bounded review amendments. Focused View and lifecycle coverage, the Testbench package suite, formatting, and the final diff checks are green after them. |
|
Tip For best results, initiate chat on the files or code changes.
The reset hooks, tokenizer coverage, and Testbench cleanup address the reported concerns. The retained Thanks for completing the focused validation. 🐇 ✅ ✏️ Learnings added
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! You are interacting with an AI system. |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/view/src/Compilers/BladeCompiler.php (1)
252-253: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winClear raw-block state when compilation fails.
Line 252 resets last-section state and Line 253 resets footer state. It does not reset
RAW_BLOCKS_CONTEXT_KEY. If compilation fails afterstoreUncompiledBlocks()and beforerestoreRawContent(), raw template content remains in the active coroutine. A latercompileString()call can reuse and grow that stale stack.Initialize the raw-block context before compilation. Clear it in a
finallyblock after compilation completes or fails.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/view/src/Compilers/BladeCompiler.php` around lines 252 - 253, Update the BladeCompiler compilation flow around CoroutineContext initialization and cleanup: initialize RAW_BLOCKS_CONTEXT_KEY before compilation, and clear it in a finally block so both successful and failed compilation remove any stored raw blocks. Preserve the existing last-section and footer context resets, and anchor the cleanup to compileString() and the storeUncompiledBlocks()/restoreRawContent() flow.
🧹 Nitpick comments (1)
docs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.md (1)
552-557: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd a malformed-nesting regression test.
Line 248 defines fail-loud behavior when tokenizer nesting is malformed. The focused test list covers commas and tokenizer-combined openers, but it does not cover malformed nesting. Add a case that verifies the expression remains unsplit and fails at the normal compilation boundary.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.md` around lines 552 - 557, Add a malformed-tokenizer-nesting regression case to the focused Blade compiler tests covering the fail-loud behavior defined around line 248: assert the expression remains unsplit and compilation fails at the normal compilation boundary. Place it with the existing comma and tokenizer-combined opener cases.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.md`:
- Line 138: Update the Blade stringable() compatibility documentation to remove
the claim that its accepted input was narrowed, or explicitly describe the
change as non-narrowing. Ensure it reflects that Laravel’s closure registration
form remains supported and Fluent::class remains valid as a string, while
keeping the statement that no useful Laravel-facing API is removed.
---
Outside diff comments:
In `@src/view/src/Compilers/BladeCompiler.php`:
- Around line 252-253: Update the BladeCompiler compilation flow around
CoroutineContext initialization and cleanup: initialize RAW_BLOCKS_CONTEXT_KEY
before compilation, and clear it in a finally block so both successful and
failed compilation remove any stored raw blocks. Preserve the existing
last-section and footer context resets, and anchor the cleanup to
compileString() and the storeUncompiledBlocks()/restoreRawContent() flow.
---
Nitpick comments:
In `@docs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.md`:
- Around line 552-557: Add a malformed-tokenizer-nesting regression case to the
focused Blade compiler tests covering the fail-loud behavior defined around line
248: assert the expression remains unsplit and compilation fails at the normal
compilation boundary. Place it with the existing comma and tokenizer-combined
opener cases.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3085edf6-bac5-44e9-b613-d6e602933806
📒 Files selected for processing (27)
docs/plans/2026-07-12-0900-framework-coroutine-state-lifecycle-audit.mddocs/plans/2026-07-12-0915-framework-coroutine-state-lifecycle-audit-ledger.mddocs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.mdsrc/boost/docs/blade.mdsrc/foundation/src/Bootstrap/HandleExceptions.phpsrc/testbench/src/Foundation/Application.phpsrc/testbench/src/PHPUnit/TestCase.phpsrc/testing/src/PHPUnit/AfterEachTestSubscriber.phpsrc/view/src/Compilers/BladeCompiler.phpsrc/view/src/Compilers/ComponentTagCompiler.phpsrc/view/src/Compilers/Concerns/CompilesConditionals.phpsrc/view/src/Compilers/Concerns/CompilesJson.phpsrc/view/src/Compilers/Concerns/CompilesStacks.phpsrc/view/src/Component.phpsrc/view/src/Concerns/ManagesComponents.phpsrc/view/src/Engines/CompilerEngine.phptests/Testbench/CreatesApplicationTest.phptests/Testbench/Foundation/ApplicationTest.phptests/Testbench/Foundation/Bootstrap/CreateVendorSymlinkTest.phptests/Testbench/TestCaseTest.phptests/Testing/Concerns/InteractsWithMockeryTest.phptests/View/Blade/BladeJsonTest.phptests/View/Blade/BladePrependTest.phptests/View/Blade/BladePushTest.phptests/View/ViewCompilerEngineTest.phptests/View/ViewComponentTest.phptests/View/ViewStaticStateTest.php
💤 Files with no reviewable changes (5)
- tests/Testbench/Foundation/Bootstrap/CreateVendorSymlinkTest.php
- tests/Testbench/CreatesApplicationTest.php
- tests/Testbench/Foundation/ApplicationTest.php
- tests/Testbench/TestCaseTest.php
- src/testbench/src/Foundation/Application.php
🚧 Files skipped from review as they are similar to previous changes (6)
- src/view/src/Compilers/ComponentTagCompiler.php
- src/view/src/Compilers/Concerns/CompilesConditionals.php
- tests/View/ViewCompilerEngineTest.php
- src/view/src/Concerns/ManagesComponents.php
- docs/plans/2026-07-12-0900-framework-coroutine-state-lifecycle-audit.md
- docs/plans/2026-07-12-0915-framework-coroutine-state-lifecycle-audit-ledger.md
Initialize raw Blade blocks at the start of each compilation and release raw-block and component-hash state in a finally block. This prevents caught compiler failures and incomplete component compilations from retaining template bytes or hash frames in coroutine or fallback process context.\n\nPreserve Laravel's public component-hash seed contract by leaving entry-time hashes intact for the immediately following compile pass, while ensuring they cannot survive that pass. Add load-bearing success and failure regressions that preserve the original exception, prove fresh subsequent compilation, and retain the seed-then-compile sequence.\n\nRecord view-41, the bounded lifecycle contract, validation, and final review status in the View plan and audit ledger.
Collaborator
Author
|
@coderabbitai Follow-up is in The raw-block finding was correct. The I did not add the malformed-nesting nitpick. Focused and complete View coverage, static analysis, formatting, and diff checks are green. The final tree has been reviewed and signed off. |
|
Tip For best results, initiate chat on the files or code changes.
Keeping component hashes available at pass entry preserves the The malformed-nesting test is not required. Compilation produces PHP, and PHP execution remains the correct failure boundary. 🐇 ✅ ✏️ Learnings added
You are interacting with an AI system. |
Collaborator
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change completes a correctness, lifecycle, and current Laravel parity pass over the View package.
It gives compiler and render state explicit ownership in long-lived workers, makes inline component publication durable, fixes compiled-view freshness and cleanup, restores current component and compiler APIs, and corrects View configuration and split-package metadata. It also ports the current full-application View integration coverage and updates the public documentation for worker-lived compiled views.
No useful Laravel-facing API is removed. Hypervel keeps its alias-first component registration and worker-singleton View architecture while making transient state coroutine-safe.
For more details, see: docs/plans/2026-08-06-0916-view-correctness-lifecycle-and-current-parity.md
Compiler and render lifecycles
The View Factory and Blade compiler remain worker-lived singletons. Transient sections, footers, raw blocks, echo overrides, render stacks, components, slots, loops, and compiled paths are owned by the active coroutine or compile pass.
This includes:
finallyon success and failure;The parent-placeholder format now uses one immutable worker salt and a compiler
v3marker. Superseded context maps, properties, helpers, and compiled output are removed rather than retained behind compatibility paths.Components and compiled views
Inline component templates are published through the existing atomic filesystem replacement boundary. Existing files are accepted only when their exact size matches, so empty templates remain valid while zero-byte and partial artifacts are repaired.
Component lookup keys use fixed-size
xxh128digests, and the reserved component namespace is replaced instead of accumulating stale paths. Compiled views memoize only paths already verified fresh, continue to honor disabled caching, recover when a previously verified file is deleted, and retain the normal one-check-per-worker fast path.Component attributes, nested conventional components, unnamed slots, backed-enum dynamic component names, conditional stack directives, named arguments, exception metadata, and generated facades now match their current supported contracts.
Configuration and package boundaries
Foundation now publishes the complete View compiler defaults with user-facing configuration comments. The View provider consumes those canonical values without duplicate fallbacks.
The split package declares the Symfony packages it uses directly, removes false Foundation and Validation requirements, and keeps Foundation as an optional suggestion for generated Vite and font directives. Dead validation middleware and its dependency are removed.
The
view:cachecommand now deduplicates canonical roots by directory boundary. Nested roots are compiled once, while path-prefix siblings and filesystem roots remain correct.Performance
The request render path gains no lock, retry, poll, watcher, network call, serialization layer, or container-resolution loop. New context operations occur at compilation and cleanup boundaries. Echo formatting adds one constant-time context read per escaped echo during compilation, not during rendered-view execution.
Inline component hashing is a fast fixed-size digest performed before the existing static lookup is populated. Filesystem validation occurs only when publishing an uncached inline template. Cache-root normalization runs only in the deployment-time command.
Verification
composer fixgit diff --checkSummary by CodeRabbit
New Features
Bug Fixes
Documentation