Skip to content

Switch to latest version of key4hep-build workflow - #12

Merged
tmadlener merged 3 commits into
masterfrom
update-key4hep-workflow
Sep 10, 2026
Merged

tmadlener merged 3 commits into
masterfrom
update-key4hep-workflow

Conversation

@tmadlener

@tmadlener tmadlener commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

  • Switch to the latest version of the key4hep-build workflow
  • Fix source-level warnings-as-errors surfaced by the key4hep nightly stack (gcc 16, C++23): deprecated implicit copy constructors in the util matrix/vector types, an anonymous typedef'd struct, an unused variable, catching exceptions by value, and redundant const-qualified casts
    ENDRELEASENOTES

This replaces the old run-lcg-view / centos7 based workflow (using
cvmfs-contrib/github-action-cvmfs and aidasoft/run-lcg-view with manual
cmake/ninja/ctest/install steps) with the current upstream
key4hep/key4hep-actions template, which handles configure, build, test and
install via the key4hep-build action running inside a CVMFS-enabled
container.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread vertex_lcfi/algo/src/vertexmass.cpp Outdated
Comment thread vertex_lcfi/util/src/vector3.cpp Outdated
tmadlener and others added 2 commits September 10, 2026 15:23
Add explicit copy constructors to the vertex_lcfi::util matrix/vector
types (Vector3, Matrix2x2/3x3/5x5/6x6, SymMatrix2x2/3x3/5x5/6x6) so the
implicitly-declared ones are no longer deprecated alongside the
user-declared copy-assignment operators; this clears the whole
-Werror=deprecated-copy family across the codebase. Also fix
non-c-typedef-for-linkage in V0Performance.h, drop an unused
accumulator in V0Performance.cc, catch lcio::Exception by reference
instead of by value, drop redundant const qualifiers on two casts in
FortranInterface.cpp, and zero-initialize a conditionally-assigned
Matrix3x3 in vertexmass.cpp to silence a maybe-uninitialized false
positive.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@tmadlener
tmadlener force-pushed the update-key4hep-workflow branch from 2e85809 to 6cfb6d5 Compare September 10, 2026 13:23
@tmadlener
tmadlener merged commit 28888e1 into master Sep 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant