Repository navigation
Conversation
Contributor
|
Bumping the minimum required version to 3.22 is also an option. |
Contributor
Author
|
That would mean that we would have to sift through the CI workflows and see which ones come with a compatible CMake versions and which ones we would need to drop. That in turn would mean thinking about what the consequences of dropping them are, so I went for the solution with as little thinking as possible ;) the failure we see in the Key4hep nightlies on Alma9 are the ones that will be fixed with #226, right? |
Contributor
Contributor
Author
|
Merging this, then #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Failures introduced in #224 and #225.