Repository navigation
test(smoke): restore a seeded search index through the packaged restore worker - #105
Merged
Merged
Conversation
…re worker The restore worker (oramaRestoreWorker) and the LZ4 binding it decodes with must load from app.asar.unpacked, and when either is missing restore quietly falls back to the main thread. The packaged smoke started from an empty profile, so it never exercised them. The profile now gets a 5 MB compressed fileChunks collection in the app's own compact format (past the 4 MB worker threshold), and the run passes only if the app logs it restored in the worker with every document inserted.
Run 42702179765 restored a seeded 5 MB LZ4 index through oramaRestoreWorker on Windows x64 and arm64, macOS arm64 and Linux x64 (parsedIn: 'worker', 800/800). The release guide describes the check, and the large-library restore leaves the manual list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restore worker (
oramaRestoreWorker) and the LZ4 binding it decodes with must load fromapp.asar.unpacked. When either is missing, restore falls back to the main thread without any error. The packaged smoke check always started from an empty profile, so it never exercised them, and the worker only runs for saved files of 4 MB or more.scripts/packaged-launch-smoke.jswrites a 5.1 MB LZ4fileChunkscollection into the throwaway profile. It holds 800 deterministic synthetic passages with 384-dim vectors, in the app's own compact format, written with the app's own codec. If the runner cannot load LZ4, seeding fails loudly.Restored fileChunks databaseline to showparsedIn: 'worker'with 800 of 800 inserted and 0 failed. A main-thread fallback or a partial restore fails the run. The summary recordsseededIndexandrestore.loadPersistedCollection.