Fix ticket capacity oversell during pending checkouts - #2
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Richard Kwaku Opoku <iamroidev@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Ticket capacity was checked only when a pending checkout row was created, while
tickets_soldwas incremented later when Paystack confirmed payment. Multiple customers could start checkout for the last available ticket before either paid; once both payments succeeded, both tickets were marked paid andtickets_soldcould exceedtotal_tickets, causing oversold events and invalid door capacity.Root cause
Pending ticket payment references did not reserve capacity, stale pending rows were hard-deleted, and payment completion unconditionally incremented
tickets_sold.Fix
capacity_reservedtracking and migrate existing pending tickets into active reservations.tickets_soldonly when payment completes.Validation
npm testinbackend(30 tests passed).