IBX-12287: Fixed tooltips disappearing on elements without line-clamp - #2013
Open
tischsoic wants to merge 1 commit into
Open
IBX-12287: Fixed tooltips disappearing on elements without line-clamp#2013tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
GrabowskiM
approved these changes
Aug 18, 2026
GrabowskiM
approved these changes
Aug 18, 2026
albozek
approved these changes
Aug 18, 2026
alekmick
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
IBX-11804 extended the ellipsis detection in
tooltips.helper.jswith:The computed value of
-webkit-line-clampon elements that don't use it is the string'none', which is truthy — so since that change every[title]element is treated as ellipsized text.parse()then only creates a tooltip whenisTitleEllipsized()decides the title text would be taller than the element; for everything else it removes thetitleattribute and creates no tooltip, permanently (re-parses skip nodes that already carrydata-original-title).Effect product-wide: tooltips silently disappeared from most non-truncated elements. Most visible on DS icon-only buttons (
padding: 0, wide content box) — e.g. short titles like "Search" or "Fields" get no tooltip while longer ones ("Add to bookmarks") pass by accident. Legacy buttons often still worked only because their narrow content boxes made the measured text taller than the element.The fix makes the clamp check honest while preserving IBX-11804's intent:
Non-clamped, non-ellipsis elements get tooltips unconditionally again;
text-overflow: ellipsisand genuineline-clamp: Nelements keep the "only when truncated" behavior added by IBX-11804.Verified on a 6.0 instance (fix applies identically — the file matches across 4.6/5.0/6.0):
-webkit-line-clamp: 2probes: short text → title stripped, no tooltip; truncated text → tooltip shows (IBX-11804 behavior intact).For QA:
Documentation: