feat(MASCORE-17804): Add fvt-gitops PostSync runner — compute enabled_apps, fix RBAC, resource prefix, and imagePullSecrets - #591
Open
Hardik-Prajapati-10 wants to merge 18 commits into
Open
Hardik-Prajapati-10 wants to merge 18 commits into
Hardik-Prajapati-10 wants to merge 18 commits into
Conversation
… for fvt-gitops job
… helm dep update - Copy updated postsync-fvt-gitops-job.yaml from fvt-gitops repo into sub-charts/ - Add cross-namespace Role+RoleBinding for mas-<instance>-core and argo namespace - Add ClusterRole+ClusterRoleBinding for clusterversions, namespaces, catalogsources - Add imagePullSecrets (ibm-entitlement) on job pod spec - Add product_channel and argo_namespace to values.yaml - Regenerate charts/fvt-gitops-runner-1.0.0.tgz via helm dependency update
…_APP_NAME env var
This reverts commit 48a5f7e.
- Replace static test_suite with enabled_apps in fvt-gitops-runner sub-chart - 600-ibm-post-sync-jobs: build enabled_apps list from ibm_suite_app_manage_install (suite always included; manage appended when Manage is installed) - Job entrypoint changed from pytest_runner.sh to run_suites.sh - instance-applications/600-ibm-post-sync-jobs/values.yaml: test_suite → enabled_apps
…erence, use fixed fvt-gitops prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: https://jsw.ibm.com/browse/MASR-10793
Story: https://jsw.ibm.com/browse/MASCORE-17804
Summary
Introduces the
fvt-gitops-runnerHelm sub-chart as a PostSync Job that runs the FVT gitops test suite after an ArgoCD sync. This PR brings all changes authored byHardik-Prajapatifrom thefvt-gitopsbranch onto a cleanmain-based branch.Changes
sub-charts/fvt-gitops-runnerwithChart.yaml,values.yaml,README.md, andpostsync-fvt-gitops-job.yaml; packaged asfvt-gitops-runner-1.0.0.tgzunderinstance-applications/600-ibm-post-sync-jobs/charts/Role/RoleBindingformas-<instance>-core,argonamespace, and aClusterRole/ClusterRoleBindingforclusterversions,namespaces, andcatalogsourcesibm-entitlementpull secret to the Job pod spec instead of the ServiceAccountbackoffLimit: 1Role/RoleBindingformas-<instance>-managenamespace; exposed OpenShift console route; addedARGOCD_APP_NAMEenv varenabled_appscomputation — dynamically derives the list of installed MAS apps from cluster state instead of a static value$prefixfrom"fvt-gitops-<test_suite>"to a fixed"fvt-gitops"to eliminate staletest_suitereferences in resource namesproduct_channelvalue — addedproduct_channel: "gitops"tovalues.yamlfor MongoDB result recording viaubi-fvtTesting
helm lintandverify-job-definitionspre-commit hooks pass