[patch] Fix applications stuck in Deleting state during deprovisioning due to incorrect sync-wave ordering - #594
Merged
Merged
Conversation
rbinns
requested changes
Sep 11, 2026
rbinns
requested changes
Sep 11, 2026
added 4 commits
September 11, 2026 16:26
…onfig CRs are cleaned up before Suite CR deletion
…ync-wave 140 so config CRs are cleaned up before Suite CR is deleted
…-mas-suite-configs-app.yaml
Raahithyaj
force-pushed
the
mascore-16865
branch
from
September 11, 2026 10:58
957c2ab to
4de3299
Compare
amitpandey0217
approved these changes
Sep 11, 2026
rbinns
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MASCORE 16865.
Root Cause:
The Suite app and config apps (SLS, Mongo, BAS etc.) were both at the same sync-wave (130). Since ArgoCD deletes in descending wave order, they were being deleted at the same time. The Suite CR deletion killed the entity manager pods that are responsible for clearing finalizers on the config CRs , leaving them stuck in Terminating forever. This caused the post-delete hook jobs to time out and fail, preventing ArgoCD from clearing its own finalizers.
Fix:
Moved the config apps from sync-wave 130 → 140 (renamed 130-ibm-mas-suite-configs-app.yaml → 140-ibm-mas-suite-configs-app.yaml). This ensures config apps delete first (wave 140) while entity managers are still alive, allowing clean finalizer removal, before Suite (wave 130) deletes last.
Validation:
Reproduced the bug on inst03/noble9, applied the fix, re-provisioned and deprovisioned , all post-delete jobs completed successfully and all ArgoCD apps deleted cleanly with no apps stuck in Deleting state
Note: This was validated on a Suite + SLS only instance (no Manage/IOT/Facilities).
Screenshot 1 — No apps stuck in Deleting
Screenshot 2 — Post-delete jobs succeeded