Skip to content

Adjust Crystal version requirement in shard.yml - #103

Merged
nobodywasishere merged 1 commit into
icyleaf:masterfrom
straight-shoota:patch-1
Nov 19, 2026
Merged

nobodywasishere merged 1 commit into
icyleaf:masterfrom
straight-shoota:patch-1

Conversation

@straight-shoota

Copy link
Copy Markdown
Contributor

Some regex literals use syntax from PCRE 2, which requires a Crystal compiler with PCRE 2. Crystal compiler releases before 1.8 only support legacy PCRE syntax.

markd/src/markd/rule.cr

Lines 73 to 74 in 5339d4a

LAST_DOMAIN_SEGMENT = /(?:[a-zA-Z0-9\-\p{Emoji_Presentation}\-]+)/
OTHER_DOMAIN_SEGMENTS = /(?:[a-zA-Z0-9\p{Emoji_Presentation}\-_]+)/

Some regex literals use syntax from PCRE 2, which requires a Crystal compiler with PCRE 2.
Crystal compiler releases before 1.8 only support legacy PCRE syntax.

https://github.com/icyleaf/markd/blob/5339d4a9c26ad5e6f7720fa062afc02b5984ea7f/src/markd/rule.cr#L73-L74
@nobodywasishere
nobodywasishere merged commit 6bb4c61 into icyleaf:master Nov 19, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants