Add temperature emitter and query APIs - #283
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @ifBars in #237.
Summary
Adds a public cross-runtime
S1API.TemperatureAPI for:Actionhandlers;Grid registration, persistence, networking, custom heatmaps, and gameplay effects remain out of scope.
Implementation notes
ScheduleOneandIl2CppScheduleOnetypes behind the public wrapper boundary.TemperatureEmitter.ToInfo()as the safe snapshot path.Validation
dotnet build S1API.Tests/S1API.Tests.csproj -c MonoMelon: passed with 0 warnings and 0 errors.dotnet build S1API.Tests/S1API.Tests.csproj -c Il2CppMelon: passed with 0 warnings and 0 errors.Schedule I_alternate): passed emitter creation, clamping, position/setter flow, event delivery, cross-wrapper removal, snapshot/query behavior, formatting, normalization, system-enabled access, and invalid-input rejection.Schedule I_public): passed the same contract, including converted-delegate cross-wrapper removal.Compatibility
stable. This PR's unpublished snapshot constructor was corrected from squared range to linear range before merge.stable; no existing stable public member was removed or changed.Closes #237