Reuse temporal column metadata

[tagliala]

Summary

• Reuse the existing columns(table) result in chrono_public_view_ddl
• Rename the local quoted column list to quoted_columns to avoid shadowing columns
• Preserve existing behavior while avoiding a duplicate metadata query

Verification

• bundle exec rubocop lib/chrono_model/adapter/ddl.rb
• bundle exec rspec spec/chrono_model/adapter/ddl_spec.rb (11 examples, 0 failures)
• bundle exec rspec spec/chrono_model (489 examples, 0 failures)
• git diff --check

Closes #422

[Copilot]

🟢 Approval recommended

The change is a small, behavior-preserving refactor that removes a duplicate metadata query and the method shadowing without altering the generated DDL or trigger arguments.

Pull request overview

This PR is a small, behavior-preserving refactor of chrono_public_view_ddl in the ChronoModel PostgreSQL adapter. It removes a duplicated columns(table) metadata lookup and eliminates a local variable that shadowed the inherited columns method (which had forced the use of self.columns(table)). It resolves issue #422.

Changes:

• Cache the result of columns(table) in a table_columns local and reuse it for both the default-value loop and the quoted-column list.
• Rename the quoted column list local from columns to quoted_columns, removing the method shadowing and the self. prefix.
• Pass quoted_columns through to chrono_create_UPDATE_trigger, preserving the previously passed value.

File summaries

File	Description
lib/chrono_model/adapter/ddl.rb	Reuses cached column metadata and renames the quoted-column local to remove method shadowing, with no behavioral change.

Notes: The linked issue's example snippet used columns(current), but the PR keeps columns(table) to match the original behavior (both prior calls used table), which is the correct choice to preserve behavior. The value passed to chrono_create_UPDATE_trigger is unchanged (an array of quoted column names with the primary key removed), so the trigger's journaling logic behaves identically.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.