Pin JSON below version 3 - #424
Merged
Merged
Conversation
Keep the current multi_json release compatible with Ruby's JSON 3 API. Remove this constraint once a compatible multi_json release is available.
tagliala
force-pushed
the
chore/pin-json-version
branch
from
September 7, 2026 10:04
3c1c2cb to
14aa92a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonto versions below 3 in the base Gemfilemulti_jsonreleases currently call the JSON 3 API incompatibly on Ruby 4. Remove the constraint when a compatiblemulti_jsonrelease is available.Verification
bundle exec rubocop Gemfilebundle exec rspec spec/chrono_model(489 examples, 0 failures)git diff --checkThe generated
gemfiles/directory is excluded from RuboCop by project configuration.