Repository navigation
refactor: inline single-use helpers; io string parsers gain a projection option - #424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlines the 44 helpers that had exactly one production caller and a body of a few lines (the moonbitlang/x style rule against single-use short helpers), keeping single copies as local functions where two call sites share one caller.
parse_csv_str/parse_ndjson_stralso gain an optionalprojectionparameter, exposing the column-subset read the lazy scan sources already use. Two candidates were skipped as scan misidentifications (json_value_as_float/json_value_as_boolhave two caller functions each). Net −44 functions, mbti unchanged apart from the two additive io signatures; tests, guards and line coverage all green.