refactor: group short verbs into one file per family - #426
Merged
Merged
Conversation
The one-verb-per-file split left a few files too small to stand alone. Series::reverse joins the row-window family it shares a gather machine with; the null-handling pairs (fill_null + drop_nulls) become one file per package; DataFrame::null_count joins the same-shaped statistical summaries; drop joins select as the projection family; the two lazy scan sources sit beside each other; and the column gather-index validation moves into the storage seam it serves. Test files follow their verbs. No signature, surface, or behaviour change - mbti and every snapshot are untouched.
The whole-repo pass over verb files: filter and reverse join window.mbt as the row-selection family (filter is the row-selection verb by its own docstring; reverse / with_row_index are the row-order half), rename joins with_columns as columns.mbt (the incremental column-set edits, beside select / drop which replace the set wholesale), and describe joins stats as the summary family. Test files follow their verbs. No signature, surface, or behaviour change.
ihb2032
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two passes over the same theme: same-family short verbs live in one file, so a verb is found by its family.
Pass one — the one-verb-per-file split had left files too small to stand alone:
Pass two — the whole-repo pass over the remaining verb files, all in frame:
Test files follow their verbs. sort and unique stay apart: at 102 / 134 lines with distinct semantics (arrangement, identity) they are not short. series/cast has no family to join. No signature, surface, or behaviour change — mbti and every guard snapshot are untouched; 1434 tests green, coverage fully covered, all guards pass.