Repository navigation
Add support for the Insta360 Link 2C (2e1a:4c03) - #3
Closed
piyushthapa wants to merge 1 commit into
Closed
piyushthapa wants to merge 1 commit into
piyushthapa wants to merge 1 commit into
Conversation
The Link 2C enumerates as USB 2e1a:4c03, which was not in the product-id allowlist, so discovery rejected it with "No supported Insta360 Link camera found." even though the camera was present and fully functional. Passing --device did not help, since the same check runs on the explicit path. Add a Model::Link2C variant and widen the tracking gate to accept it. The gate change is safe: check_unit still verifies that extension unit 11 carries the AI GUID afterwards, so a device without the unit fails cleanly rather than issuing vendor requests blindly. Verified on real Link 2C hardware (uvcvideo 7.2.5, kernel 7.2.5): linkctl devices -> 1 Insta360 Link 2C /dev/video4 2e1a:4c03 pan -145..145 deg, tilt -90..100 deg, zoom 1.0x..4.0x zoom 2 / right 20 / center / zoom 1 all applied while streaming info reports unit 9 [info/mode], unit 10 [image], unit 11 [ai] with the expected AI GUID, and `tracking` reads state successfully Left is_tested() false for Link2C so the "recognised, not validated" note still prints; flipping it is the maintainer's call. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Link 2C enumerates as USB 2e1a:4c03, which was not in the product-id allowlist, so discovery rejected it with "No supported Insta360 Link camera found." even though the camera was present and fully functional. Passing --device did not help, since the same check runs on the explicit path.
Add a Model::Link2C variant and widen the tracking gate to accept it. The gate change is safe: check_unit still verifies that extension unit 11 carries the AI GUID afterwards, so a device without the unit fails cleanly rather than issuing vendor requests blindly.
Verified on real Link 2C hardware (uvcvideo 7.2.5, kernel 7.2.5):
linkctl devices -> 1 Insta360 Link 2C /dev/video4 2e1a:4c03
pan -145..145 deg, tilt -90..100 deg, zoom 1.0x..4.0x
zoom 2 / right 20 / center / zoom 1 all applied while streaming
info reports unit 9 [info/mode], unit 10 [image], unit 11 [ai] with the
expected AI GUID, and
trackingreads state successfullyLeft is_tested() false for Link2C so the "recognised, not validated" note still prints; flipping it is the maintainer's call.