Repository navigation
fix(a11y): start the language toggle label with its visible text - #113
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
@dependabot rebase |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #111. After rebasing, #103 still fails on the same
label-content-name-mismatchrule: axe-core 4.14 strips parentheticals (removeParentheticals) before matching, so the "(EN)" suffix isn't counted.The label now starts with the visible code: "EN – Ganti bahasa ke English" / "ID – Switch language to Bahasa Indonesia". A screen reader reads "EN" first, which matches what sighted voice-control users see and say.
Closes #109
Type of change
fix– bug fixHow to test
bun run test -- src/components/landing src/lib/i18n@dependabot rebase.E2E (local build)should pass on/.Checklist
bun run lint,bunx tsc --noEmitandbun run testpass locally (landing, i18n, login tests)bun run buildpasses (string-only change; CI covers it)AGENTS.md*.server.ts/ server functions and are never exposed viaVITE_*mainNotes for reviewers
On
/privacyand/terms, axe reports the failing node as.text-xs. That's the same toggle button (its first class); the legal pages render the sameSiteChromeheader. I couldn't run axe in a real browser locally (jsdom returns "incomplete"), so E2E on this PR is the real check.🤖 Generated with Claude Code