Skip to content

fix(a11y): start the language toggle label with its visible text - #113

Merged
ilramdhan merged 1 commit into
mainfrom
fix/a11y-language-toggle-axe414
Oct 30, 2026
Merged

ilramdhan merged 1 commit into
mainfrom
fix/a11y-language-toggle-axe414

Conversation

@ilramdhan

Copy link
Copy Markdown
Owner

Summary

Follow-up to #111. After rebasing, #103 still fails on the same label-content-name-mismatch rule: axe-core 4.14 strips parentheticals (removeParentheticals) before matching, so the "(EN)" suffix isn't counted.

The label now starts with the visible code: "EN – Ganti bahasa ke English" / "ID – Switch language to Bahasa Indonesia". A screen reader reads "EN" first, which matches what sighted voice-control users see and say.

Closes #109

Type of change

  • fix – bug fix

How to test

  1. bun run test -- src/components/landing src/lib/i18n
  2. Once merged, rebase chore(deps): Bump the minor-and-patch group across 1 directory with 27 updates #103 with @dependabot rebase. E2E (local build) should pass on /.

Checklist

  • bun run lint, bunx tsc --noEmit and bun run test pass locally (landing, i18n, login tests)
  • bun run build passes (string-only change; CI covers it)
  • Follows the architecture rules in AGENTS.md
  • Database changes: none
  • No secrets, tokens or personal data in code, logs, fixtures or screenshots
  • Server-only secrets stay in *.server.ts / server functions and are never exposed via VITE_*
  • Accessibility considered: this is the a11y fix
  • UI strings added for both Indonesian and English
  • PR title follows Conventional Commits
  • Docs updated: not needed
  • No force-push / history rewrite of commits already on main

Notes for reviewers

On /privacy and /terms, axe reports the failing node as .text-xs. That's the same toggle button (its first class); the legal pages render the same SiteChrome header. I couldn't run axe in a real browser locally (jsdom returns "incomplete"), so E2E on this PR is the real check.

🤖 Generated with Claude Code

axe-core 4.14 drops parentheticals before matching label-content-name-mismatch,
so the "(EN)" suffix added in #111 did not count. Leading with the visible
code ("EN – Ganti bahasa ke English") satisfies WCAG 2.5.3 Label in Name.

Refs #109

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ilramdhan ilramdhan added bug Something isn't working accessibility Barrier affecting people with disabilities labels Oct 30, 2026
Copilot AI balanced review requested due to automatic review settings October 30, 2026 02:27
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
demo-2ndbrain.ilramdhan.dev Ready Ready Preview Oct 30, 2026 2:28am UTC
second-brain Ready Ready Preview Oct 30, 2026 2:28am UTC

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T02:27:30.973229Z
We couldn’t complete this review. Comment @codex review to try again.
be1ca8b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@ilramdhan
ilramdhan merged commit 998e28a into main Oct 30, 2026
20 checks passed
@ilramdhan
ilramdhan deleted the fix/a11y-language-toggle-axe414 branch October 30, 2026 02:32
@ilramdhan

Copy link
Copy Markdown
Owner Author

@dependabot rebase

This branch was successfully deployed

2 active deployments
Preview – demo-2ndbrain.ilramdhan.dev — be1ca8b4 Deployed Oct 30, 2026 by vercel[bot]
Preview – second-brain — be1ca8b4 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Barrier affecting people with disabilities bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(a11y): language toggle accessible name doesn't contain its visible text

2 participants