Skip to content

feat(landing): add VITE_LANDING_PAGE toggle for private instances - #119

Open
hitsmedia-grup wants to merge 1 commit into
ilramdhan:mainfrom
hitsmedia-grup:feat/landing-toggle
Open

hitsmedia-grup wants to merge 1 commit into
ilramdhan:mainfrom
hitsmedia-grup:feat/landing-toggle

Conversation

@hitsmedia-grup

Copy link
Copy Markdown

Replace localStorage/cookie with build-time env var. Fixes hydration mismatch, eliminates client-side flash, provides instance-level control.

  • Add VITE_LANDING_PAGE (default enabled, set false to skip landing)
  • landingPageEnabled() helper following googleAuthEnabled() pattern
  • Redirect in index.tsx beforeLoad (SSR-safe)
  • Remove settings UI, localStorage, cookie (not in upstream/main)

Closes #107

Summary

Closes #

Type of change

  • feat – new feature
  • fix – bug fix
  • refactor / perf – no behavior change / performance
  • docs / test / chore / ci
  • Breaking change (describe the migration path below)

How to test

Screenshots / recordings

Checklist

  • bun run lint, bunx tsc --noEmit and bun run test pass locally
  • bun run build passes (required for routing, server function or config changes)
  • Follows the architecture rules in AGENTS.md (data hooks in src/lib/data.ts, task edits via TaskDialogProvider/useTaskActions, PageContainer, soft delete, …)
  • Database changes: new migration in drizzle/migrations/ registered in meta/_journal.json, RLS enabled with policies + grants, src/integrations/supabase/types.ts regenerated
  • No secrets, tokens or personal data in code, logs, fixtures or screenshots
  • Server-only secrets stay in *.server.ts / server functions and are never exposed via VITE_*
  • Accessibility considered: keyboard reachable, labelled controls, visible focus, sufficient contrast (see ACCESSIBILITY.md)
  • UI strings added for both Indonesian and English where the i18n layer applies
  • PR title follows Conventional Commits (it drives the version bump and CHANGELOG.md; don't edit the changelog by hand)
  • Docs updated (README.md, AGENTS.md if an architecture rule changed)
  • No force-push / history rewrite of commits already on main (keep published history intact)

Notes for reviewers

Replace localStorage/cookie with build-time env var. Fixes hydration mismatch,
eliminates client-side flash, provides instance-level control.

- Add VITE_LANDING_PAGE (default enabled, set false to skip landing)
- landingPageEnabled() helper following googleAuthEnabled() pattern
- Redirect in index.tsx beforeLoad (SSR-safe)
- Remove settings UI, localStorage, cookie (not in upstream/main)

Closes ilramdhan#107
@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown

@hitsmedia-grup is attempting to deploy a commit to the ilramdhan's projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: opsi untuk menonaktifkan landing page

1 participant