Move small-sigma Gaussian blur return to a helper - #3092
Closed
fyrsta7 wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this draft because follow-up benchmarking did not show a large enough performance gain to justify this as an upstream performance PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves the small-sigma identity return used by
GaussianBlurParameters::new_from_sigmainto a cold helper, leaving the normal positive-sigma path as the straight-line path.Why this can improve performance
The
sigma <= 0.0case returns an identity kernel and is not the normal blur construction path. Keeping that path in a cold helper lets the common Gaussian-kernel setup stay a little smaller and more direct.Validation
git diff --checkcargo checkBenchmark
Current machine, release microbenchmark, 9 samples, median:
GaussianBlurParameters::new_from_sigmacalls