Handle zero-sized images in filtering operations - #3096
Closed
fyrsta7 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3026 and fixes #3028 by handling zero-sized image inputs in
filter3x3and theunsharpenpath instead of letting them reach loops that assume a non-empty image.Details
For zero-width or zero-height images, there are no pixels to filter. This returns the correctly shaped output image early in those cases.
filter3x3also returns early when the input is too small to contain any interior pixels.This adds regression coverage for zero-sized
filter3x3andunsharpencalls.Validation
git diff --checkcargo fmt --all --checkcargo test -p image --lib zero_sized_images