PNG: Avoid allocations when disposing APNG frames - #3102
Merged
Conversation
197g
reviewed
Aug 26, 2026
197g
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes APNG background and previous-frame disposal to operate directly on the underlying image rows. Previously, these paths created temporary buffers before clearing or restoring a region, resulting in unnecessary allocations and memory copies. The new implementation performs the same work directly in the frame buffers without changing the public API or using unsafe code.
The existing six WPT APNG reference tests pass. Local measurements produced the following results:
The benchmarks were run locally and are not included in this PR.
Tested with
cargo test --test reference_images -- wptandcargo clippy --lib -- -D warnings.AI disclosure: I used Codex with GPT-5.6 Sol at
xhighreasoning effort to help identify the allocation, implement the optimization, and construct the local benchmarks. I reviewed and tested the resulting change.