Skip to content

Handle some variants of the micro sign µ #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdoube wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle some variants of the micro sign µ #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/net/imagej/units/DefaultUnitService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,14 @@ private boolean definedInternally(String unitName) {
*/
private String sanitizeUnitString(final String unitName) {
// Convert the mu symbol into "u".
return unitName.replace("\\u00B5", "u").replace("\\u00b5", "u");
return unitName.replace("\\u00B5", "u")
.replace("\\u00b5", "u")
//micro sign
.replace("µ", "u")
.replace("\\u03BC", "u")
.replace("\\u03bC", "u")
//Greek mu
.replace("μ", "u");
}

private Unit parseUnit(final String unitName) {
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/net/imagej/units/DefaultUnitServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,31 @@ public void testBadConversion() {
@Test
public void testMu() {
final DefaultUnitService c = new DefaultUnitService();
//sanity - u is used by the rest of the conversion logic
assertEquals(0.1, c.value(100_000, "um", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "um"), 0.0);

//micro sign
assertEquals(0.1, c.value(100_000, "\\u00B5m", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "\\u00B5m"), 0.0);

assertEquals(0.1, c.value(100_000, "\\u00b5m", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "\\u00b5m"), 0.0);

//Greek small mu
assertEquals(0.1, c.value(100_000, "\\u03BCm", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "\\u00b5m"), 0.0);

assertEquals(0.1, c.value(100_000, "\\u03bCm", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "\\u00b5m"), 0.0);

//Unicode µ \\u00B5 micro sign
assertEquals(0.1, c.value(100_000, "µm", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "µm"), 0.0);

//Unicode μ \\u03bc Greek small letter mu
assertEquals(0.1, c.value(100_000, "μm", "meter"), 1e-16);
assertEquals(1_000_000.0, c.value(1, "meter", "μm"), 0.0);

}
}
Loading