Add progress and success output to remote install/update - #5
Merged
Merged
Conversation
Remote install-ref/install/update previously printed nothing until a single terse "install order: ..." line at the very end, making a slow relay or Blossom fetch look hung with no confirmation that anything happened. Add stderr progress (connecting, resolving, downloading, matching npack search's existing style) and a per-package "installed <publisher>/<name> <version>" stdout line on success, matching the wording already used by local .npk installs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-ref/install <ref>/updatepreviously printed nothing during the whole resolve-download-install pipeline, only a terseinstall order: ...line at the very end. On a slow relay or Blossom lookup (up to the existing network timeout) this looked hung, with no way to tell it was making progress or that anything actually happened.Connecting to N relay(s)... done in Xs,Resolving <publisher>/<name>...,Downloading <publisher>/<name> <version> (N mirror(s))... done in Xs (N bytes)-- matching the stylenpack searchalready uses, so stdout stays script-friendly.installed <publisher>/<name> <version>line per package on success, matching the wording local.npkinstalls already use, in addition to the existinginstall order: ...summary.wss://relay.damus.io) with a nonexistent package -- connect/resolve progress prints correctly and the error is clear.Test plan
cargo fmt --checkcargo clippy --all-targetscargo test(37 passed, no behavior change to covered paths)docs/npack.1regenerated vianpack man(no diff)🤖 Generated with Claude Code