Add AppStream metadata support (roadmap Phase 1) - #7
Merged
Merged
Conversation
Adds an optional `app` object to the manifest (summary, description, homepage, license, categories, icon, screenshots, desktop_file, release_date), validates icon/desktop_file paths and desktop-entry syntax at pack time, and adds `npack appstream` to render a console-application or desktop-application AppStream <component> document from a built .npk. CI installs appstreamcli and validates a generated sample document. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appobject to the manifest for AppStream-compatible metadata:summary,description,homepage,license,categories,icon,screenshots,desktop_file,release_date.npack packvalidatesicon/desktop_fileare safe package-relative paths that exist in the source tree, and validatesdesktop_fileas a syntactically correct freedesktop.org Desktop Entry file (Type,Name, andExecwhenType=Application).npack appstream <artifact> [--output <metainfo.xml>], rendering aconsole-application(with<provides><binary>) ordesktop-application(with<launchable type="desktop-id">) AppStream<component>document from a built.npk's manifest.appstreamcliand validates a generated sample document withappstreamcli validate --no-net, confirmed locally to pass (only informational hints remain, no errors/warnings).This closes out roadmap Phase 1: "an npack package can describe itself in the language already understood by Linux application stores."
Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --all-features(no warnings)cargo test(45 passing, including new desktop-file/AppStream tests)pack→appstream→appstreamcli validate --no-netagainst a real desktop-application and a console-application sample, both passing🤖 Generated with Claude Code