fix(checkout-widgets): stop stuck Loading overlays under React 19 - #2938
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit f4649f5
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
biom3 LoadingOverlay orphans modals when unmounted while visible (useControlledOverlay vs useIsMounted); still present in 0.32.11. - LoadingView: inline overlay (call sites mount/unmount this view) - Handover: keep biom3 LoadingOverlay mounted; toggle visible Co-authored-by: Cursor <cursoragent@cursor.com>
alex-connolly
force-pushed
the
fix/checkout-widgets-react19-stuck-loading
branch
from
July 31, 2026 22:07
67f6287 to
f4649f5
Compare
ermyas
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@biom3/react@^0.29.4(~0.29.11); latest is0.32.11and still has the sameuseControlledOverlayunmount race.LoadingView: stop usingLoadingOverlay(these views are conditionally mounted/unmounted across ~20 call sites + Suspense). Use an inline overlay that tears down with the tree.Handover: keep biom3LoadingOverlay, always mounted,visible={Boolean(loader)}instead of{loader && <LoadingOverlay visible>}.Test plan
2.24.3still reproduces