Keep mbassador intact under R8 and commit config writes synchronously - #128
Merged
Conversation
The v0.1.0 release crashed on the first SMB connection: R8 renamed mbassador's handler-invocation classes, which smbj's event bus looks up by reflection ((SubscriptionContext) constructor). Keep net.engio.mbassy and runtime annotations. The crash also raced SharedPreferences.apply() and lost the pair that had just been saved, so SecurePreferences now commits synchronously; its callers already run on Dispatchers.IO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing the v0.1.0 release on a Galaxy S26 (Android 16) and saving the first pair crashed the app immediately:
(SubscriptionContext)constructor and reads@Handlerannotations. The existing keep rule only coveredcom.hierynomus.**.net.engio.mbassy.**is now kept andRuntimeVisibleAnnotationsretained.SharedPreferences.apply(), so the pair the user had just entered was gone on relaunch.SecurePreferences.editnow usescommit(); writes are rare, hold credentials, and already run onDispatchers.IO.Verified on the device with this build (0.1.1): pair saved, first pass synced 4 files, real-time mode pushes a new local file to the NAS, a file created on the NAS arrives on the phone in about 10 s, and local deletes propagate. No crash.