a conjunction in a condition is refused, not swallowed - #15
Merged
Conversation
The == and != operators take everything to their right as a STRING, so "x != null && x > 5" parsed cleanly as "x differs from the text null && x > 5" - always true. Live run of 16.08: a repair wrote exactly that, the skill saved without a complaint, and it would have pulled logs for EVERY pod while looking like it filtered them. The message says where the other half goes: a guard against emptiness onto the step's when, a second branch as a nested if. The contains form with a single pipe is untouched - there the pipe is that form's own syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The == and != operators take everything to their right as a STRING, so
"x != null && x > 5" parsed cleanly as "x differs from the text
null && x > 5" - always true. Live run of 16.08: a repair wrote exactly that,
the skill saved without a complaint, and it would have pulled logs for EVERY pod
while looking like it filtered them.
The message says where the other half goes: a guard against emptiness onto the
step's when, a second branch as a nested if. The contains form with a single
pipe is untouched - there the pipe is that form's own syntax.