Make hosted voice voicemail setting explicit - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
This PR makes the hosted voice live test request its asserted voicemail-detection setting explicitly.
Description
The hosted outbound voice fixture now tells OpenCode to set
voicemailDetectiontodisabledwhen placing the call. This aligns the model-controlled tool input with the persisted-call assertion before the test exercises post-call SMS settlement.Reason
The optional per-call setting could otherwise vary with model tool arguments and fail the live test before it reached the behavior under test.
Decisions
Testing
npm test: 65 files and 799 tests pass.npm run lint: passes.npm run typecheck: passes.npm run build: passes.voicemailDetection=disabledand continue through exact post-call SMS settlement.