Skip to content

fix(MangaUpdates): handle missing thumbnail url - #92

Merged
niclimcy merged 1 commit into
inkdex:0.9/stablefrom
IntermittentlyRupert:0.9/stable
Oct 2, 2026
Merged

niclimcy merged 1 commit into
inkdex:0.9/stablefrom
IntermittentlyRupert:0.9/stable

Conversation

@IntermittentlyRupert

Copy link
Copy Markdown
Contributor

Summary

Some MangaUpdates manga don't have images. Currently, the extension handles this by falling back to an empty string for the thumbnailUrl, which causes an error.

This PR switches to using an actually valid fallback thumbnailUrl.

Checklist

Making changes

For updates to existing extensions

  • Bumped the version value in pbconfig.ts for each modified extension.

For new extensions

  • Generated tests with npx paperback-cli test --generate EXTENSION_NAME.

Testing changes

  • npm run conformance passes.
  • npm test -- EXTENSION_NAME passes.
  • Bundled the extension and verified it works in the Paperback app.

Committing changes

  • Commit messages follow the existing convention (type(Scope): summary, e.g. fix(EXTENSION_NAME): ...).

AI assistance

Pick one:

  • This PR contains no AI-assisted changes.
  • This PR is AI-assisted. I manually reviewed every change and added an Assisted-by: AGENT_NAME:MODEL_VERSION trailer to each AI-assisted commit.

@niclimcy niclimcy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@niclimcy
niclimcy merged commit 13d7ca4 into inkdex:0.9/stable Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants