chore(log4js): shim _log instead of log #2672
Merged
Merged
Conversation
aryamohanan
commented
Jul 23, 2026
|
|
||
| function instrumentLog4jsLogger(loggerModule) { | ||
| shimmer.wrap(loggerModule.prototype, 'log', shimLog); | ||
| shimmer.wrap(loggerModule.prototype, '_log', shimLog); |
Contributor
Author
There was a problem hiding this comment.
aryamohanan
changed the title
kirrg001
reviewed
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old shim wrapped
log(), which received the raw value passed by the user (for example,"ERROR"or3). So we neededgetLevel()to convert it into aLevelobject.Now we're wrapping
_log(), which log4js calls after it has already resolved the level. That meanslevelis always aLevelobject, sogetLevel()is no longer needed.This also lets us remove the extra mapping logic (
LEVEL_MAP,LOG_LEVEL,shouldCaptureLogSpan, andresolveLogLevel), since we can use the resolvedLevelobject directly.