Conversation
tkatila
commented
Sep 24, 2026
tkatila
commented
Contributor
- some additions to makefile
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain in workload execution, image mirroring, and Makefile target filtering.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Adds operator E2E workloads for IAA and DSA VFIO, with hardware-specific Makefile targets and image override support.
Changes:
- Adds IAA and DSA VFIO workload execution.
- Adds categorized operator E2E targets.
- Adds
accel-config-demoimage override handling.
| File | Summary |
|---|---|
test/e2e/operator/utils/operator_utils.go |
Adds IAA demo image overrides; OCP image mirroring also needs updating. |
test/e2e/operator/operator.go |
Adds IAA and DSA VFIO workloads; restart policy, timeout, and naming issues require changes. |
Makefile |
Adds plugin-specific targets; default filtering and VFIO target coverage require changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events --ginkgo.label-filter "operator && !(gpu || iaa)" $(E2E_DRYRUN) -delete-namespace-on-failure=false | ||
|
|
||
| e2e-operator: e2e-operator-reminder | ||
| @$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events --ginkgo.label-filter "operator && !(gpu || vfio)" $(E2E_DRYRUN) -delete-namespace-on-failure=false |
| @$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events --ginkgo.label-filter "operator && qat" $(E2E_DRYRUN) -delete-namespace-on-failure=false | ||
|
|
||
| e2e-operator-dsa: e2e-operator-reminder | ||
| @$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events --ginkgo.label-filter "operator && dsa && !vfio" $(E2E_DRYRUN) -delete-namespace-on-failure=false |
| "intel-deviceplugin-operator", | ||
| "crypto-perf", | ||
| "dsa-dpdk-dmadevtest", | ||
| "accel-config-demo", |
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
tkatila
force-pushed
the
test-e2e-iaa-dsa-workloads
branch
from
September 24, 2026 12:56
c0a962f to
ab5122d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.