Add pfnGetArgumentProperties4 with 8D dims support and refactored argument properties struct - #57
Open
jburcham-intel wants to merge 2 commits into
Open
Add pfnGetArgumentProperties4 with 8D dims support and refactored argument properties struct#57jburcham-intel wants to merge 2 commits into
jburcham-intel wants to merge 2 commits into
Conversation
jburcham-intel
force-pushed
the
tensor_dimensions
branch
from
August 27, 2026 23:00
9d777b4 to
b4f42e7
Compare
lmielick
reviewed
Aug 28, 2026
lmielick
reviewed
Aug 28, 2026
jwludzik
reviewed
Aug 28, 2026
jburcham-intel
force-pushed
the
tensor_dimensions
branch
from
August 28, 2026 16:59
b4f42e7 to
8d1abc8
Compare
…ument properties struct
jburcham-intel
force-pushed
the
tensor_dimensions
branch
from
August 28, 2026 17:07
8d1abc8 to
a609138
Compare
jwludzik
approved these changes
Sep 1, 2026
razvanapetroaie
approved these changes
Sep 2, 2026
lmielick
reviewed
Sep 2, 2026
| ///< tensor names associated with this argument | ||
| ze_graph_argument_name_type_t nameType, ///< [in] type of the argument name to query | ||
| size_t* pSize, ///< [in,out] size of pNames buffer in bytes | ||
| char* pNames ///< [in,out][optional] null-terminated name(s) associated with this argument |
There was a problem hiding this comment.
Maybe a pre-mature optimization, but it might make sense to also return number of names in the buffer, so the caller can reserve a vector or query the number of strings with pNames = NULL.
lmielick
approved these changes
Sep 2, 2026
pereanub
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new graph argument properties query (
ze_graph_argument_properties_4_t/pfnGetArgumentProperties4, extension v1.20) to support tensors with rank up to 8 (ZE_MAX_GRAPH_ARGUMENT_DIMENSIONS_SIZE_8), replacing the 5D cap in v3. Rather than just widening the existing struct, this cleans up accumulated redundancy/dead weight from v1-v3:networkPrecision/devicePrecisionandnetworkLayout/deviceLayoutcollapse into singleprecision/layoutfields reporting the compiled argument's properties — what callers actually need to allocate and bind buffers correctly.quantReverseScale/quantZeroPoint(added in v2, never consumed) are removed.associated_tensor_namesarray (char[32][256], ~8KB per query result) is removed from the struct entirely. A newpfnGetArgumentAssociatedTensorNamesquery replaces it, using the same query-size-then-fetch pattern already used bypfnGetNativeBinary/pfnGraphBuildLogGetString/pfnQueryNetworkGetSupportedLayers— no arbitrary name-count/length cap, and zero cost for the common case of an argument with no associated names.Also adds
ze_graph_argument_value_strides_2_t(new stypeZE_STRUCTURE_TYPE_GRAPH_ARGUMENT_STRIDES_2), an 8D-capable variant ofze_graph_argument_value_strides_tpassed through the existingpfnSetArgumentValue2'spArgValueparameter, disambiguated bystype. This keeps the 8D story symmetric between reading argument properties and setting per-argument strides, without changing the layout of the existing 5D struct in place (widening a trailing array under a sharedstypewould be an unsafe ABI break for any driver/plugin version skew).Changes
ZE_GRAPH_EXT_VERSION_CURRENTto 1.20; backfill missing ddi-table version placeholder comments for 1.17-1.19.ZE_MAX_GRAPH_ARGUMENT_DIMENSIONS_SIZE_8,ze_graph_argument_properties_4_t,pfnGetArgumentProperties4,pfnGetArgumentAssociatedTensorNames,ze_graph_argument_value_strides_2_t.ZE_STRUCTURE_TYPE_GRAPH_ARGUMENT_PROPERTIES_4(0x12),ZE_STRUCTURE_TYPE_GRAPH_ARGUMENT_STRIDES_2(0x13).pfnSetArgumentValue/pfnSetArgumentValue2pArgValuedoc comment to name each accepted struct type explicitly.