This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Avoid copies in getChecked (cherry-pick from upstream) (#151) - #170
Merged
andrey-golubev merged 2 commits intoNov 10, 2025
Merged
andrey-golubev merged 2 commits into
andrey-golubev merged 2 commits into
Conversation
Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
AlexandruLorinti
marked this pull request as draft
November 7, 2025 15:01
andrey-golubev
approved these changes
Nov 7, 2025
Contributor
Author
|
Updated expected copy count from "1" to "2" for CopyCountGet and CopyCountGetChecked tests, as there are currently 2 copies generated, while in previous npu-plugin-llvm there was just 1 copy generated. In current npu-plugin-llvm as well as in upstream llvm there are 2 copies as the test calls first verifyInvariants which internally calls verify, in mlir/include/mlir/IR/StorageUniquerSupport.h:201 |
AlexandruLorinti
marked this pull request as ready for review
November 10, 2025 10:41
ermilindwalekar
pushed a commit
to ermilindwalekar/npu-plugin-llvm
that referenced
this pull request
Nov 27, 2025
…ntel#170) Duplicate of PR merged on npu/release/19.x intel#151 Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate of PR merged on npu/release/19.x #151
Cherry-pick from upstream llvm llvm/llvm-project#147721; adding std::move to getChecked method.
JIRA ticket
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
Other related tickets