[PB-6258] feat: send global search filters server-side through the SDK - #2069
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
580ae49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16415c19.drive-web.pages.dev |
| Branch Preview URL: | https://pb-6258-search-filters-sdk.drive-web.pages.dev |
This was referenced Jul 24, 2026
7 tasks
…lter # Conflicts: # src/views/Home/components/NavbarGlobalSearch.tsx
…s the empty state
…rch shows the empty state" This reverts commit c420428.
victor-ferro
marked this pull request as ready for review
July 29, 2026 14:42
CandelR
reviewed
Jul 31, 2026
CandelR
left a comment
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed, waiting to add the sdk to approve in order to not merge by error
…lter # Conflicts: # src/views/Home/components/SearchTypeFilter.tsx
…lter # Conflicts: # src/views/Home/components/SearchDateFilter.tsx
…ed SearchFilterRow
… PB-6258-search-type-filter
… PB-6258-search-date-filter
… PB-6258-search-size-filter
CandelR
previously approved these changes
Aug 6, 2026
larryrider
previously approved these changes
Aug 14, 2026
# Conflicts: # package.json # yarn.lock
|
larryrider
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First of a 4-PR stack implementing advanced search filters for the global search (PB-6258).
Adds a
SearchFiltersstate and asearch.service.tsthat buildsGlobalSearchOptionsand sends the search through the SDK, moving filtering server-side. The legacy client-side filtering (which only operated on the 10 returned results) and its filter chips are removed.GlobalSearchOptions,SearchFileCategoryand the newgetGlobalSearchItemssignature, not published yet. CI will stay red until that SDK version ships; then a final commit will bump@internxt/sdkinpackage.json+yarn.lockand the PR will be marked ready for review.Related Issues
Relates to PB-6258 (JIRA).
Related Pull Requests
Checklist
Testing Process
search.service.ts.