refactor: extract the shared auth page layout - #92
Open
victor-ferro wants to merge 2 commits into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
object-storage-management-web | fb468ab | Commit Preview URL Branch Preview URL |
Aug 12 2026, 04:05 PM |
Deploying object-storage-web with
|
| Latest commit: |
fb468ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4dc012f2.object-storage-web.pages.dev |
| Branch Preview URL: | https://feat-pb-6703-auth-page-layou.object-storage-web.pages.dev |
victor-ferro
marked this pull request as ready for review
August 14, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been added
In this pull request I pull the two-column layout out of
LoginPageViewinto anAuthPageLayoutcomponent, together with the shared input styles. The login screen renders exactly as before; the recovery screens in the next PR reuse the same layout instead of copying it.Each console's copy — title, headline, description and feature pills — moves into its own
console-brandingfile, so the login pages just spread it.Why
Without this, adding the two recovery screens per console would mean four copies of the same 90 lines of layout.
It also fixes classes that were rendering nothing:
text-red-500,text-gray-900andplaceholder-gray-400do not exist in our Tailwind preset, which replaces the default palette instead of extending it. The error message on failed login was inheriting its colour rather than showing red.