Skip to content

fix(eval): per-item DER guards zero-haraqat paragraphs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronaldtse merged 1 commit into from
Aug 31, 2026
Merged

fix(eval): per-item DER guards zero-haraqat paragraphs #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/gpu/modal_distill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,13 +1205,18 @@ def der_ce_from_preds(preds) -> dict:
)
return {"der_ce": round(total_der, 4), "n": len(inputs)} # evaluator already returns %

def item_der_from_preds(preds) -> list[float]:
ders = []
def item_der_from_preds(preds) -> list[float | None]:
ders: list[float | None] = []
for pred, gt in zip(preds, gts, strict=True):
_, _, d, _, _ = E.caculate_errors_on_sentences(
[pred], [gt], gt_missing_diacritic_is_error=False
)
ders.append(float(d))
try:
_, _, d, _, _ = E.caculate_errors_on_sentences(
[pred], [gt], gt_missing_diacritic_is_error=False
)
ders.append(float(d))
except ZeroDivisionError:
# paragraph carries no scorable haraqat positions; the
# aggregate call skips it, single-item calls cannot
ders.append(None)
return ders

teacher_preds = windowed_paragraphs(teacher, tok, inputs, window=window)
Expand All @@ -1221,11 +1226,12 @@ def item_der_from_preds(preds) -> list[float]:
"teacher": der_ce_from_preds(teacher_preds),
"student": der_ce_from_preds(student_preds),
}
t_ders = item_der_from_preds(teacher_preds)
s_ders = item_der_from_preds(student_preds)
result["paired_bootstrap"] = paired_bootstrap([
s - t
for s, t in zip(
item_der_from_preds(student_preds), item_der_from_preds(teacher_preds), strict=True
)
for s, t in zip(s_ders, t_ders, strict=True)
if s is not None and t is not None
])
result["gate_delta"] = round(result["student"]["der_ce"] - result["teacher"]["der_ce"], 4)
result["gate_pass"] = result["gate_delta"] <= 0.5
Expand Down
Loading