fix(lint): ruff clean on main; real F821 in logit-mode distill - #139
Merged
Conversation
…still The F821 was a real latent bug: MTP checkpoint lines from the #114 wiring were pasted into the logit-mode distiller save block where mtp_head never exists — any logit-mode run would NameError at its first step checkpoint. The lines belong only in distill_sequence. The rest: import sorting, unused zipfile, quoted annotation, E501 signature wraps, zip strict=, context manager for models.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI is red on ruff (15 errors accumulated across the concurrent merges). Fixes:
ruff check clean; all touched files compile. CI pytest is the authority for behavior (local env lacks the dev extras).