Skip to content

fix: parity_model precisions split #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronaldtse merged 2 commits into from
Sep 3, 2026
Merged

fix: parity_model precisions split #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2501972
fix: parity_model iterates the split precisions, not string chars
Sep 3, 2026
e980a5b
fix: same split for margin_model's precision loop
Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gpu/modal_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def stage(event: str) -> None:
meta_path = Path("/root/interscript-ml", spec["metadata"])
mid = re.search(r"^id:\s*(\S+)", meta_path.read_text(encoding="utf-8"), re.M).group(1)
reports: dict[str, str] = {}
for precision in precisions:
for precision in [q.strip() for q in precisions.split(",") if q.strip()]:
zip_path = out_dir / f"{mid}-{precision}.zip"
stage(f"onnx decode {precision}")
report = run_parity(model, zip_path, pairs, max_len=128, reference=reference)
Expand Down Expand Up @@ -382,7 +382,7 @@ def margin_model(
meta_path = Path("/root/interscript-ml", spec["metadata"])
mid = re.search(r"^id:\s*(\S+)", meta_path.read_text(encoding="utf-8"), re.M).group(1)
reports: dict[str, str] = {}
for precision in precisions:
for precision in [p.strip() for p in precisions.split(",") if p.strip()]:
zip_path = out_dir / f"{mid}-{precision}.zip"
if not zip_path.exists():
reports[precision] = "zip not exported (skipped)"
Expand Down
Loading