fix(distill): byt5 decode_joined mojibake — all Arabic labels poisoned - #35
Merged
Conversation
added 3 commits
August 24, 2026 06:28
…, X-API-Key auth, /infer + /health)
…decode convert_ids_to_tokens on a byte-level vocab returns each byte token as a raw char; joining them double-encodes the text. This poisoned every Arabic label generated under 5.14 (both students trained on mojibake targets — their identical 83.08 DER was the bare-text constant, not a capacity verdict). Byte-exactness asserted locally; umt5 path unchanged. ara-diac-small relabels onto teacher_labels_v2.jsonl.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 3 commits
August 24, 2026 08:35
…l); constant-time key compare
… never enters path construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan