fix(api): resolve model ids through the models.yaml index - #59
Merged
Conversation
_zip_path hardcoded "<id>-fp32.zip" — every int8/int4 variant (ara-diac-small-1.0-int8, tha-g2p-small-1.0-int8/-int4) 404'd as "unknown model", and heb-diac-1.1 (index filename heb.zip, volume copy heb-diac-1.1-fp32.zip) missed too. Resolution now goes through the index contract with precision-convention fallbacks, matched by equality against the volume listing (no user input in path construction). Health reports zips + model dirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live symptom: POST /v1/infer {"model":"ara-diac-small-1.0-int8"} ->
404 "unknown model" while /v1/models advertises it. The Modal server
resolved ids by hardcoding the -fp32.zip naming convention instead of
the models.yaml contract; variant zips (int8/int4) and
differently-named volume copies (heb-diac-1.1) never matched.
{id}-{precision}.zip -> {id}-fp32.zip), unit-tested against the real
models.yaml with the exact live failure cases
path construction (CWE-22)
Deploy + live verification follows (int8, int4, g2p, fp32 cases).