Skip to content

refactor: use LINQ Where in pagination link builder #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erlend Ellefsen (erlendellefsen) merged 1 commit into from
Sep 3, 2026
+8 −7
Merged

refactor: use LINQ Where in pagination link builder #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions JsonApiToolkit/Mapping/JsonApiMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,14 +421,15 @@ bool preserveQuery
string query = queryStart >= 0 ? selfLink[queryStart..] : string.Empty;

var builder = new Microsoft.AspNetCore.Http.Extensions.QueryBuilder();
foreach (var kvp in Microsoft.AspNetCore.WebUtilities.QueryHelpers.ParseQuery(query))
foreach (
var kvp in Microsoft
.AspNetCore.WebUtilities.QueryHelpers.ParseQuery(query)
.Where(kvp =>
!kvp.Key.Equals("page[number]", StringComparison.OrdinalIgnoreCase)
&& !kvp.Key.Equals("page[size]", StringComparison.OrdinalIgnoreCase)
)
)
{
if (
kvp.Key.Equals("page[number]", StringComparison.OrdinalIgnoreCase)
|| kvp.Key.Equals("page[size]", StringComparison.OrdinalIgnoreCase)
)
continue;

foreach (string? value in kvp.Value)
builder.Add(kvp.Key, value ?? string.Empty);
}
Expand Down