fix: use Path.Join instead of Path.Combine in CLI test - #213
Merged
Conversation
Contributor
Author
|
Context on CodeQL alert 54: the second argument here is a file name built from a fresh GUID, so it can never be an absolute path and |
Daniel Kristiansen (dakristia)
marked this pull request as ready for review
September 2, 2026 10:35
Daniel Kristiansen (dakristia)
requested a review
from Erlend Ellefsen (erlendellefsen)
as a code owner
September 2, 2026 10:35
Daniel Kristiansen (dakristia)
enabled auto-merge (squash)
September 2, 2026 10:35
Erlend Ellefsen (erlendellefsen)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CodeQL alert 54.
Replaces
Path.CombinewithPath.JoininCliIntegrationTests.csto avoid silently dropping earlier path arguments.