Update to jellyfin 12

[rlauuzo]

Jellyfin dependencies now use the stable-only 12.* floating version. Restores select the latest stable Jellyfin 12.x release (currently 12.1.0), excluding prereleases and Jellyfin 13. The current minimum ABI and documented server requirement are 12.1. Each release derives its target ABI from the actually restored Jellyfin packages and commits it with the release metadata, so future stable 12.x updates cannot leave the advertised ABI behind.

Verified dependency resolution, NuGet selection against future stable/prerelease/13 candidates, the .NET Release build (zero warnings/errors), formatting, actionlint, and release ABI synchronization/rejection cases. The frontend prerequisite intro-skipper/segment-editor#244 is merged. Rebuilt successfully from current frontend master, packaged the DLL, and verified all 68 embedded files plus entry-point/missing-asset cache headers on Jellyfin 12.1. Base-branch conflicts are resolved while preserving the Jellyfin 12 release version series and dispatch-only workflow. This direct update supersedes #18.

Summary by Sourcery

Upgrade the plugin for Jellyfin 12 while aligning frontend packaging, asset delivery, release automation, and documented compatibility requirements.

New Features:

• Update the plugin to target Jellyfin 12.1 and .NET 10, with stable Jellyfin 12.x dependency resolution and release metadata synchronization.
• Improve embedded frontend asset caching with entry-point revalidation, entity tags, and safe missing-resource responses.
• Refresh the embedded Segment Editor frontend and configuration-page lifecycle handling.

Bug Fixes:

• Prevent stale configuration-page state and playback behavior when navigating between plugin pages.
• Ensure frontend mount identifiers remain aligned when packaging the generated configuration page.

Enhancements:

• Simplify and branch-isolate the release workflow so Jellyfin 12 releases are dispatched from the master workflow and publish against the correct ref.
• Upgrade GitHub Actions tooling used by build and release workflows.
• Update build requirements and user-facing documentation for Jellyfin 12 and .NET 10.

Build:

• Retarget project builds and release artifacts from net9.0 to net10.0.

Deployment:

• Record the restored stable Jellyfin package version as the release target ABI and preserve the Jellyfin 12 release series.

Documentation:

• Document the Jellyfin 12.1 minimum server requirement, stable dependency selection, and .NET 10 build prerequisites.

Chores:

• Remove the obsolete Jellyfin ruleset.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the plugin to target Jellyfin 12 and .NET 10, aligning build, packaging, and documentation with the new framework/ABI and simplifying linting/ruleset configuration.

File-Level Changes

Change	Details	Files
Retarget plugin and packaging metadata to Jellyfin 12 and .NET 10.	Update plugin manifest target ABI from 10.11.5.0 to 12.0.0.0 Update plugin manifest framework from net9.0 to net10.0 Adjust manifest changelog entry to mention Jellyfin 12 compatibility	build.yaml
Align documentation with new Jellyfin and .NET requirements.	Change installation path references from net9.0 to net10.0 Increase minimum Jellyfin Server version requirement to 12.0.0 Update documented build requirement from .NET SDK 9.0 to 10.0 Update note about plugin target framework from net9.0 to net10.0	README.md
Update CI workflows to use .NET 10 and the new output path.	Update actions/setup-dotnet configuration in build workflow from 9.0.x to 10.0.x Update build workflow artifact path from net9.0 to net10.0 Update actions/setup-dotnet configuration in release workflow from 9.0.x to 10.0.x Update release packaging step to zip the net10.0 build output Update actions/setup-dotnet configuration in CodeQL workflow from 9.0.x to 10.0.x	.github/workflows/build.yml .github/workflows/release.yml .github/workflows/codeql.yml
Adjust or remove editor and ruleset configuration to match the new setup.	Modify editor configuration (details not shown in diff) to align with updated project style or tooling Update VS Code launch/tasks configurations (details not shown in diff) for the new target framework/runtime Remove the Jellyfin-specific ruleset file, implying use of default or alternative code analysis settings	.editorconfig .vscode/launch.json .vscode/tasks.json jellyfin.ruleset
Retarget the plugin project to .NET 10 to match Jellyfin 12 requirements.	Update the project target framework from net9.0 to net10.0 (inferred from surrounding changes, details not shown in diff)	SegmentEditorPlugin/SegmentEditorPlugin.csproj

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The removal of jellyfin.ruleset without a replacement means any custom analyzer/rule configuration tied to Jellyfin conventions will be lost; if that wasn’t intentional, consider either keeping it or migrating its settings into .editorconfig before dropping the file.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The removal of `jellyfin.ruleset` without a replacement means any custom analyzer/rule configuration tied to Jellyfin conventions will be lost; if that wasn’t intentional, consider either keeping it or migrating its settings into `.editorconfig` before dropping the file.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)

• .editorconfig
• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Previous Review Summaries (16 snapshots, latest commit 40f4a83)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 40f4a83)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• .github/workflows/release.yml
• README.md

Previous review (commit 944d28f)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• README.md
• SegmentEditorPlugin/SegmentEditorPlugin.csproj
• build.yaml

Previous review (commit e999900)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Previous review (commit b51f99f)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• .github/segment-editor-master.sha
• Directory.Build.props

Review Notes

Incremental review of 3cc4b58 → 9aeaae9 (commit chore: release v12.0.7.0). The only changes are the automated release outputs: the upstream segment-editor state SHA and the patch version bump from 12.0.6.0 to 12.0.7.0 (applied consistently to Version, AssemblyVersion, and FileVersion), which matches the bump logic in .github/workflows/release.yml. No security, performance, or correctness issues found in the changed lines.

Previous review (commit 9aeaae9)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• .github/segment-editor-master.sha
• Directory.Build.props

Review Notes

Incremental review of 3cc4b58 → 9aeaae9 (commit chore: release v12.0.7.0). The only changes are the automated release outputs: the upstream segment-editor state SHA and the patch version bump from 12.0.6.0 to 12.0.7.0 (applied consistently to Version, AssemblyVersion, and FileVersion), which matches the bump logic in .github/workflows/release.yml. No security, performance, or correctness issues found in the changed lines.

Previous review (commit 3cc4b58)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Previous review (commit 18625c7)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since d5e0c9dc bumps the plugin version to 12.0.5.0, refreshes the segment-editor frontend pin SHA, and updates hashed asset references in configPage.html to match the rebuilt bundle. No bugs, security issues, or breaking changes found in the changed lines.

Prior review findings on .editorconfig (lines 237, 416, 419) and SegmentEditorPlugin/Controllers/SegmentEditorController.cs (line 64) remain on files outside this incremental diff and are not carried forward.

Previous review (commit d5e0c9d)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since a28710f8 bumps the plugin version to 12.0.4.0, refreshes the segment-editor frontend pin SHA, and updates hashed asset references in configPage.html to match the rebuilt bundle. No bugs, security issues, or breaking changes found in the changed lines.

Prior review findings on .editorconfig (lines 237, 416, 419) and SegmentEditorPlugin/Controllers/SegmentEditorController.cs (line 64) remain on files outside this incremental diff and are not carried forward.

Previous review (commit a28710f)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since 9a81686 bumps the plugin version to 12.0.3.0, refreshes the segment-editor frontend pin SHA, and updates hashed asset references in configPage.html to match the rebuilt bundle. No bugs, security issues, or breaking changes found in the changed lines.

Prior review findings on .editorconfig (lines 237, 416, 419) and SegmentEditorPlugin/Controllers/SegmentEditorController.cs (line 64) remain on files outside this incremental diff and are not carried forward.

Previous review (commit 9a81686)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/segment-editor-master.sha
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since a74d7b0 bumps the plugin version to 12.0.2.0, refreshes the segment-editor frontend pin SHA, and updates hashed asset references in configPage.html to match the rebuilt bundle. No bugs, security issues, or breaking changes found in the changed lines.

Prior review findings on .editorconfig (lines 237, 416, 419) and SegmentEditorPlugin/Controllers/SegmentEditorController.cs (line 64) remain on files outside this incremental diff and are not carried forward.

Previous review (commit a74d7b0)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)

• .github/segment-editor-master.sha
• .github/workflows/release.yml
• Directory.Build.props
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change updates the release workflow to target the 12.0 branch directly, bumps the plugin version to 12.0.1.0 for the Jellyfin 12 / .NET 10 migration, and refreshes the frontend asset hashes in configPage.html to match the rebuilt segment-editor bundle. No bugs, security issues, or breaking changes found in the changed lines.

No C# source files were changed in this diff, so the design-pattern review does not apply to the incremental changes.

Prior review findings on .editorconfig (lines 237, 416, 419) and SegmentEditorPlugin/Controllers/SegmentEditorController.cs (line 64) remain on files outside this incremental diff and are not carried forward.

Previous review (commit ebf053b)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/workflows/build.yml
• .github/workflows/release.yml
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since the prior review adds CI logic that derives the frontend SPA mount element id from the built dist/index.html and rewrites the config page mount <div> to match, with RuntimeError guards and a count=1 scoped replacement. The corresponding configPage.html default mount id (segment-editor-root) is consistent with that logic. No bugs, security issues, or breaking changes found in the changed lines.

Prior .editorconfig suggestions (lines 237, 416, 419) are on a file outside this incremental diff and are therefore not carried forward in this incremental review.

Previous review (commit 6976305)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .github/workflows/build.yml
• .github/workflows/release.yml
• SegmentEditorPlugin/Configuration/configPage.html

Notes

The incremental change since the prior review adds CI logic that derives the frontend SPA mount element id from the built dist/index.html and rewrites the config page mount <div> to match, with RuntimeError guards and a count=1 scoped replacement. The corresponding configPage.html default mount id (segment-editor-root) is consistent with that logic. No bugs, security issues, or breaking changes found in the changed lines.

Prior .editorconfig suggestions (lines 237, 416, 419) are on a file outside this incremental diff and are therefore not carried forward in this incremental review.

Previous review (commit eab3b80)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	3

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
.editorconfig	237	Comment says "disable warning" but severity is set to error for SA1513 (Closing brace should be followed by blank line)
.editorconfig	416	Comment says "error on" but severity is set to suggestion for CA3003 (file path injection)
.editorconfig	419	Comment says "error on" but severity is set to suggestion for CA3006 (process command injection)

Files Reviewed

• .editorconfig - 3 issues (carried forward; file unchanged since prior review, findings still active)
• SegmentEditorPlugin/Configuration/configPage.html - reviewed new changes (PATCH 4/4); no new issues found

Fix these issues in Kilo Cloud

Previous review (commit 8517d52)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	3

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
.editorconfig	237	Comment says "disable warning" but severity is set to error for SA1513 (Closing brace should be followed by blank line)
.editorconfig	416	Comment says "error on" but severity is set to suggestion for CA3003 (file path injection)
.editorconfig	419	Comment says "error on" but severity is set to suggestion for CA3006 (process command injection)

Files Reviewed (10 files)

• .editorconfig - 3 issues (comment/severity mismatches in analyzer rules; re-verified, unchanged since prior review)
• .github/workflows/build.yml - reviewed, no issues
• .github/workflows/codeql.yml - reviewed, no issues
• .github/workflows/release.yml - reviewed, no issues
• .vscode/launch.json - reviewed, no issues
• .vscode/tasks.json - reviewed, no issues
• README.md - reviewed, no issues
• SegmentEditorPlugin/Configuration/configPage.html - reviewed, no issues
• SegmentEditorPlugin/SegmentEditorPlugin.csproj - reviewed, no issues
• build.yaml - reviewed, no issues
• jellyfin.ruleset - deleted, no issues

Fix these issues in Kilo Cloud

Previous review (commit a4b7068)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	3

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
.editorconfig	237	Comment says "disable" but severity is set to error
.editorconfig	416	Comment says "error on" but severity is set to suggestion
.editorconfig	419	Comment says "error on" but severity is set to suggestion

Files Reviewed (3 files)

• .editorconfig - 3 issues (comment/severity mismatches in added analyzer rules)
• SegmentEditorPlugin/SegmentEditorPlugin.csproj - reviewed, no issues
• build.yaml - reviewed, no issues

Note

This PR does not modify any C# source files (.cs), so design pattern review of changed code is not applicable. The review above covers .NET configuration and analyzer rule changes only.

Fix these issues in Kilo Cloud

---

_{Reviewed by gpt-5.6-luna · Input: 0 · Output: 0 · Cached: 0}

[capy-ai]

Capy found 1 potential issue (1 medium).

View 2 other findings in Capy.

[capy-ai]

Capy found no issues.

[capy-ai]

Capy found no issues.

[capy-ai]

Capy found no issues.

[capy-ai]

Capy found no issues.

View 1 other finding in Capy.

[capy-ai]

Capy found no issues.