Skip to content

For isni recognition take the url(s) into account as well - #151

Open
wgresshoff wants to merge 3 commits into
inveniosoftware:masterfrom
ulbmuenster:take-isni-urls-into-account
Open

For isni recognition take the url(s) into account as well#151
wgresshoff wants to merge 3 commits into
inveniosoftware:masterfrom
ulbmuenster:take-isni-urls-into-account

Conversation

@wgresshoff

Copy link
Copy Markdown
Contributor

❤️ Thank you for your contribution!

Description

The idutils isni validator fails to recognize complying ids if they start with the ISNI url. This PR fixes this.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@wgresshoff
wgresshoff requested a review from tmorrell September 4, 2026 15:32

@tmorrell tmorrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Might be nice to add a test_isni function to clarify the behavior for orcid, since orcids are isnis but we're going to return false if someone uses the isni url. I believe the current behavior is what we want, but a test would help formalize that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants