Skip to content
This repository was archived by the owner on Feb 4, 2021. It is now read-only.

Update ripple polyfil to support flex on the touchable - #99

Open
mlabrum wants to merge 1 commit into
invertase:masterfrom
mlabrum:patch-5
Open

Update ripple polyfil to support flex on the touchable#99
mlabrum wants to merge 1 commit into
invertase:masterfrom
mlabrum:patch-5

Conversation

@mlabrum

@mlabrum mlabrum commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Hey,

I found that on IOS the TouchableOpacity won't respect the child flex (where TouchableNativeFeedback seems to) and that it sometimes requires a kick to force it to flex

pre flex
touchable-pre

after flex
touchable-after

(Trying to make the whole area a button)

@Salakar

Salakar commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

Could we not use the existing style prop to pass this along - Incase other styles other than flex are wanted? Thoughts?

@mlabrum

mlabrum commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

the existing style prop updates the inner and outer View within the IOS TouchableOpacity, I needed to be able to set styles directly on the outer container of TouchableOpacity, to be able to get the flex needed

We could adjust this to be a generic touchableOpacityStyles prop?

@dantman

dantman commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Better innerStyle/outerSyle handling that works the same with and without the polyfill would be better.

@CLAassistant

CLAassistant commented Jul 11, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants